Closed Bug 955146 Opened 10 years ago Closed 10 years ago

Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.

Categories

(Chat Core :: IRC, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1718 at 2012-10-04 17:42:00 UTC ***

Timestamp: 04/10/12 19:37:08
Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
Source File: resource:///modules/ircBase.jsm
Line: 1089
Source Code:
irc

Steps to reproduce:
Type "test
" (with a trailing line break) in the input box, and send it.
Attached patch Untested patch (obsolete) — Splinter Review
*** Original post on bio 1718 as attmnt 1933 at 2012-10-04 17:50:00 UTC ***

We were only checking for emptiness on the initial message, not after splitting it by line breaks.
Attachment #8353689 - Flags: review?
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353689 [details] [diff] [review]
Untested patch

*** Original change on bio 1718 attmnt 1933 at 2012-10-04 17:51:59 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353689 - Flags: review? → review?(florian)
*** Original post on bio 1718 as attmnt 1934 at 2012-10-04 18:26:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353690 - Flags: review?(florian)
Comment on attachment 8353689 [details] [diff] [review]
Untested patch

*** Original change on bio 1718 attmnt 1933 at 2012-10-04 18:26:55 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353689 - Attachment is obsolete: true
Attachment #8353689 - Flags: review?(florian)
Comment on attachment 8353690 [details] [diff] [review]
Untested patch without garbage

*** Original change on bio 1718 attmnt 1934 at 2012-10-04 23:33:31 UTC ***

Thanks for the quick fix! :)
Attachment #8353690 - Flags: review?(florian) → review+
*** Original post on bio 1718 at 2012-10-04 23:50:18 UTC ***

http://hg.instantbird.org/instantbird/rev/da62debcd5ae
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.