Closed Bug 955148 Opened 10 years ago Closed 10 years ago

Follow-up to account preferences layout changes

Categories

(Instantbird Graveyard :: Account manager, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: clokep)

References

Details

Attachments

(1 file)

*** Original post on bio 1720 at 2012-10-06 13:25:00 UTC ***

I'm getting the following error when opening the preferences dialog for accounts now (and the advanced page refuses to show). I think that was introduced with the recent layout changes there.


Timestamp: 06.10.2012 15:14:17
Error: ReferenceError: box is not defined
Source File: chrome://instantbird/content/account.js
Line: 133
Attached patch PatchSplinter Review
*** Original post on bio 1720 as attmnt 1937 at 2012-10-06 15:04:00 UTC ***

This is my bad.
Attachment #8353693 - Flags: review?
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Blocks: 955132
Comment on attachment 8353693 [details] [diff] [review]
Patch

*** Original change on bio 1720 attmnt 1937 at 2012-10-06 15:05:19 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353693 - Flags: review? → review?(florian)
Comment on attachment 8353693 [details] [diff] [review]
Patch

*** Original change on bio 1720 attmnt 1937 at 2012-10-07 17:58:38 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353693 - Flags: review?(florian) → review+
*** Original post on bio 1720 at 2012-10-07 23:02:54 UTC ***

Thanks for the quick review.

http://hg.instantbird.org/instantbird/rev/c6969171b1c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.