Closed Bug 955154 Opened 10 years ago Closed 10 years ago

L10n repackaging doesn't work on a build from a source tarball

Categories

(Instantbird Graveyard :: Localization, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

*** Original post on bio 1725 at 2012-10-13 21:05:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch FixSplinter Review
*** Original post on bio 1725 as attmnt 1958 at 2012-10-13 21:05:00 UTC ***

Our l10n repackaging code in instantbird/locales/Makefiles.in calls client.py with the "checkout-l10n" action, but that fails in the fixup_repo_options function because there's no existing .hg folder at the root of the source directory.
The simple solution is to tell client.py to skip Instantbird as it's obviously not what we are trying to checkout when doing l10n.
Attachment #8353717 - Flags: review?(clokep)
Comment on attachment 8353717 [details] [diff] [review]
Fix

*** Original change on bio 1725 attmnt 1958 at 2012-10-13 22:27:31 UTC ***

Seems reasonable to me!
Attachment #8353717 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1725 at 2012-10-25 12:13:12 UTC ***

http://hg.instantbird.org/instantbird/rev/e7e237578f53
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.