Closed Bug 955173 Opened 10 years ago Closed 10 years ago

Add Odnoklassniki protocol

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: unghost)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

*** Original post on bio 1742 by Alexander L. Slovesnik <unghost AT gmail.com> at 2012-10-27 13:41:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
*** Original post on bio 1742 as attmnt 2014 by unghost AT gmail.com at 2012-10-27 13:41:00 UTC ***

This patch adds support for Odnoklassniki social network service ( http://en.wikipedia.org/wiki/Odnoklassniki ). Odnoklassniki currently has an Alexa Internet traffic ranking 7 for Russia ( http://www.alexa.com/topsites/countries/RU ), 9 for Ukraine ( http://www.alexa.com/topsites/countries/UA ) and 13 for in Estonia ( http://www.alexa.com/topsites/countries/EE ).
Icons for patch has been taken from Miranda's Odnoklassniki Status Pack ( http://miranda-planet.com/forum/index.php/topic/8468-odnoklassniki-status-pack/ ) released under Creative Commons Attribution-Share Alike 3.0 Unported license.
Attachment #8353774 - Flags: review?(clokep)
Comment on attachment 8353774 [details] [diff] [review]
Add Odnoklassniki protocol v.0.1

*** Original change on bio 1742 attmnt 2014 at 2012-11-02 02:39:27 UTC ***

This change looks fine to me.
Attachment #8353774 - Flags: review?(clokep) → review+
*** Original post on bio 1742 at 2012-11-02 02:43:23 UTC ***

I need a comment to assign this. :) Thanks!
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [checkin-needed]
*** Original post on bio 1742 at 2012-11-03 04:19:58 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/53a7ec35ff7f

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
*** Original post on bio 1742 as attmnt 2036 by unghost AT gmail.com at 2012-11-03 14:06:00 UTC ***

I've checked today's build and Odnoklassniki doesn't work. Following patch fixes the problem for me.
Attachment #8353796 - Flags: review?(clokep)
*** Original post on bio 1742 by unghost AT gmail.com at 2012-11-03 14:07:18 UTC ***

Reopen for additional patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*** Original post on bio 1742 at 2012-11-03 18:03:11 UTC ***

Comment on attachment 8353796 [details] [diff] [review] (bio-attmnt 2036)
Fix Odnoklassniki protocol v.0.1

I can't test this, do we have a link with connection info?
*** Original post on bio 1742 by Alexander L. Slovesnik <unghost AT gmail.com> at 2012-11-03 18:33:28 UTC ***

(In reply to comment #6)
> Comment on attachment 8353796 [details] [diff] [review] (bio-attmnt 2036) [details]
> Fix Odnoklassniki protocol v.0.1
> 
> I can't test this, do we have a link with connection info?

I've sent you login/password for test account.
Connection info can be found on http://wiki.qip.ru/%D0%9E%D0%B4%D0%BD%D0%BE%D0%BA%D0%BB%D0%B0%D1%81%D1%81%D0%BD%D0%B8%D0%BA%D0%B8#.D0.9D.D0.B0.D1.81.D1.82.D1.80.D0.BE.D0.B9.D0.BA.D0.B8_.D1.81.D0.BE.D0.B5.D0.B4.D0.B8.D0.BD.D0.B5.D0.BD.D0.B8.D1.8F

If I setup Odnoklassniki as usual XMPP account, I don't have to use xmpp.odnoklassniki.ru as connection server, it just works out of box. I'm not quite why original patch doesn't work.
*** Original post on bio 1742 by Alexander L. Slovesnik <unghost AT gmail.com> at 2012-11-03 18:35:11 UTC ***

(In reply to comment #7)
> If I setup Odnoklassniki as usual XMPP account, I don't have to use
> xmpp.odnoklassniki.ru as connection server, it just works out of box. I'm not
> quite why original patch doesn't work.
s/quite/quite sure
*** Original post on bio 1742 at 2012-11-03 18:40:51 UTC ***

(In reply to comment #7)

> If I setup Odnoklassniki as usual XMPP account, I don't have to use
> xmpp.odnoklassniki.ru as connection server, it just works out of box. I'm not
> quite why original patch doesn't work.

This is because our current JS-XMPP code doesn't support querying DNS SRV records yet (this is covered by https://bugzilla.mozilla.org/show_bug.cgi?id=787369).
Comment on attachment 8353796 [details] [diff] [review]
Fix Odnoklassniki protocol v.0.1

*** Original change on bio 1742 attmnt 2036 at 2012-11-05 02:16:09 UTC ***

This changes does look OK, I wonder if we should add a comment above this line saying something about using odnoklassniki.ru once DNS SRV is supported (referring to the Mozilla bug Florian quoted). I'll let Florian decide that before committing (in which case he should add an r- to this).
Attachment #8353796 - Flags: review?(clokep) → review+
Attachment #8353796 - Flags: review?(florian)
Comment on attachment 8353796 [details] [diff] [review]
Fix Odnoklassniki protocol v.0.1

*** Original change on bio 1742 attmnt 2036 at 2012-11-05 22:40:44 UTC ***

(In reply to comment #10)
> I wonder if we should add a comment above this line
> saying something about using odnoklassniki.ru once DNS SRV is supported
> (referring to the Mozilla bug Florian quoted).

I don't mind either way, so I'll take the patch as-is.
Attachment #8353796 - Flags: review?(florian)
*** Original post on bio 1742 at 2012-11-06 10:37:19 UTC ***

http://hg.instantbird.org/instantbird/rev/baba3c99e424

Please verify it works correctly in the new nightly :-).
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
*** Original post on bio 1742 by unghost AT gmail.com at 2012-11-06 19:09:19 UTC ***

Verified.
Status: RESOLVED → VERIFIED
There was missing email mapping information for this bug during the BIO to BMO merge, manually assigning this bug.
Assignee: bugzilla → unghost
Blocks: 1789724
You need to log in before you can comment on or make changes to this bug.