Closed
Bug 955178
Opened 10 years ago
Closed 10 years ago
_originalMsg property not set on message following unread ruler when rejoining bubbles
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: aleth, Assigned: aleth)
Details
(Whiteboard: [1.3-blocking])
Attachments
(1 file)
1.31 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1747 at 2012-10-30 20:52:00 UTC *** STR Have a series of tweets by the same person, joined into a single bubble. Reply to one of the tweets (but not the first). Sometimes, but not always, the wrong tweet is replied to. (This can most easily be detected by the wrong list of nicks being added to the input box)
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1747 at 2012-10-30 20:59:47 UTC *** NB It's also detectable from the status bar, which displays the tweet being replied to.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.3-blocking]
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1747 at 2012-10-30 21:10:10 UTC *** Consistently reproducible on the same tweets (once you notice it), but behaviour disappears for these tweets if you put the conversation on hold and then restore.
Comment 3•10 years ago
|
||
*** Original post on bio 1747 at 2012-10-30 21:16:27 UTC *** (In reply to comment #2) > Consistently reproducible on the same tweets (once you notice it), but > behaviour disappears for these tweets if you put the conversation on hold and > then restore. Random guess: could this have something to do with the unread ruler? Like for example not re-adding the _originalMsg JS properties (see http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#529) where needed after removing the ruler?
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1747 as attmnt 2023 at 2012-10-30 22:11:00 UTC *** (In reply to comment #3) > Random guess: could this have something to do with the unread ruler? Like for > example not re-adding the _originalMsg JS properties (see > http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#529) > where needed after removing the ruler? Spot on :) This property was not set for the message immediately following the ruler on rejoining the bubble. (NB This also caused magic copy to ignore this message.)
Attachment #8353783 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Summary: Reply to tweet sometimes replies to wrong target when replying to a next message tweet → _originalMsg property not set on message following unread ruler when rejoining bubbles
Assignee | ||
Updated•10 years ago
|
Component: Twitter → Conversation
Product: Chat Core → Instantbird
Comment 5•10 years ago
|
||
Comment on attachment 8353783 [details] [diff] [review] Patch *** Original change on bio 1747 attmnt 2023 at 2012-10-30 22:22:09 UTC *** Assuming you have tested this, it looks OK. Thanks for fixing this! :)
Attachment #8353783 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.3-blocking] → [1.3-blocking][checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 1747 at 2012-10-31 01:25:01 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/110a690ad94a Thanks for the quick fix aleth!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.3-blocking][checkin-needed] → [1.3-blocking]
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•