Closed Bug 955185 Opened 10 years ago Closed 10 years ago

IRC says messages are unhandled when they are partially handled

Categories

(Chat Core :: IRC, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

References

Details

Attachments

(1 file)

*** Original post on bio 1753 at 2012-11-03 19:33:00 UTC ***

This is what I have in the terminal:

irc: :rajaniemi.freenode.net CAP * LS :account-notify extended-join identify-msg multi-prefix sasl
irc: {"rawMessage":":rajaniemi.freenode.net CAP * LS :account-notify extended-join identify-msg multi-prefix sasl","command":"CAP","params":["*","LS","account-notify extended-join identify-msg multi-prefix sasl"],"servername":"rajaniemi.freenode.net","cap":{"subcommand":"LS","parameter":"sasl","disable":false,"sticky":false,"ack":false}}
irc: Sending:
CAP END
irc: Unhandled IRC message: :rajaniemi.freenode.net CAP * LS :account-notify extended-join identify-msg multi-prefix sasl
Blocks: 955004
*** Original post on bio 1753 at 2012-11-03 21:32:31 UTC ***

This isn't a bug at all. Not all the CAPs are handled, so we mark it as such. We do the same for ISUPPORT, etc.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
*** Original post on bio 1753 at 2012-11-03 21:44:47 UTC ***

This message really looks like the whole line hasn't been handled/understood. Aren't some of these things handled correctly?
Wouldn't it make more sense to mark the message as handled and LOG the CAPs that we don't support? (LOG is a loglevel that isn't shown by default, I think that the "Unhandled IRC message" is a WARN (although I haven't checked) that's visible by default).
*** Original post on bio 1753 at 2012-11-04 14:26:27 UTC ***

We should at least strip the CAPs which are actually handled from the message.
Severity: normal → minor
Status: RESOLVED → REOPENED
OS: Other → All
Hardware: x86 → All
Resolution: INVALID → ---
Summary: Unhandled IRC message: :rajaniemi.freenode.net CAP * LS :account-notify extended-join identify-msg multi-prefix sasl → IRC says messages are unhandled when they are partially handled
Attached patch PatchSplinter Review
*** Original post on bio 1753 as attmnt 2195 at 2013-01-16 02:28:00 UTC ***

CAP and ISUPPORT now iterate through the list of things that have been supported and print out those explicitly...along with the full raw IRC message. I think this is sufficient for Florian's concerns, but also allows us to have all the debugging information we need.
Attachment #8353958 - Flags: review?(florian)
Assignee: nobody → clokep
Status: REOPENED → ASSIGNED
Comment on attachment 8353958 [details] [diff] [review]
Patch

*** Original change on bio 1753 attmnt 2195 at 2013-01-17 12:32:14 UTC ***

Looks good to me - thanks.
Attachment #8353958 - Flags: review?(florian) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1753 at 2013-01-18 23:13:43 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/587b40a3e133
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.