Closed Bug 955207 Opened 10 years ago Closed 10 years ago

Background of element containing the nickname not snuggling up to main bubble border

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: benediktp)

Details

(Whiteboard: [1.3-wanted])

Attachments

(2 files)

*** Original post on bio 1775 at 2012-11-08 00:33:00 UTC ***

There's gap between the curved corner of the element containing the nickname and the enclosing main bubble border. It's because of a miscalculated border-radius of the inner element.

The border-radius is defining the shape at the outer border edge while the border-width extends to the inside [1]. That means the correct border-radius at the inside of the border is (border-radius - border-width).


[1] http://dev.w3.org/csswg/css3-background/#border-radius
Attached patch PatchSplinter Review
*** Original post on bio 1775 as attmnt 2068 at 2012-11-08 00:39:00 UTC ***

Fix
Attachment #8353828 - Flags: review?(bugzilla)
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
*** Original post on bio 1775 as attmnt 2069 at 2012-11-08 00:41:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8353828 [details] [diff] [review]
Patch

*** Original change on bio 1775 attmnt 2068 at 2012-11-08 19:40:04 UTC ***

Once you pointed it out, I also managed to spot the problem on Linux. Not with all font sizes, and not on all Bubbles (maybe some rounding issue somewhere), but it definitely happens.

Thanks for fixing this! :)
Attachment #8353828 - Flags: review?(bugzilla) → review+
Severity: trivial → minor
OS: Windows 7 → All
Hardware: Other → All
Whiteboard: [checkin-needed][1.3-wanted]
*** Original post on bio 1775 at 2012-11-09 00:38:54 UTC ***

Thanks Mic! http://hg.instantbird.org/instantbird/rev/9e67eb680bbb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed][1.3-wanted] → [1.3-wanted]
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.