Closed
Bug 955211
Opened 10 years ago
Closed 10 years ago
Focusing Instantbird by clicking an unselected conversation tab doesn't mark the current conversation as read
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: aleth)
Details
(Whiteboard: [1.3-wanted])
Attachments
(1 file)
1.85 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1779 at 2012-11-08 16:42:00 UTC *** It's a very common situation when using Instantbird on an external monitor.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
OS: Other → All
Hardware: x86 → All
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1779 at 2012-11-08 20:33:51 UTC *** I can't reproduce this. I tried: - Open IB with two IRC conversation tabs - Send new messages to the visible conversation tab while IB does not have focus - Switch to IB by clicking on the other conversation tab. Result: the previously visible tab keeps its unread flag.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1779 at 2012-11-08 20:36:14 UTC *** So, OK, that's precisely what is not wanted ;)
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1779 at 2012-11-08 21:05:04 UTC *** Just noting this has nothing to do with the unread ruler timers added in http://hg.instantbird.org/instantbird/rev/c03c096f856b
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1779 as attmnt 2076 at 2012-11-09 13:20:00 UTC *** This ensures the current tab is marked as read when clicking on another tab, which should take care of the problem. The unread ruler will not be removed in this case though, which should help people who haven't actually read all the new messages yet. This may not be the right behaviour, we shall see. I've also slightly reduced the unread ruler timer, which I think was a tad too long; this is unrelated and should possibly land separately.
Attachment #8353836 -
Flags: review?(florian)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [1.3-wanted]
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8353836 [details] [diff] [review] Patch *** Original change on bio 1779 attmnt 2076 at 2012-11-09 23:40:24 UTC *** When testing with a single monitor, this isn't as obviously wanted as it was when I actually used Instantbird on an external monitor, but let's test this in nightlies.
Attachment #8353836 -
Flags: review?(florian) → review+
Reporter | ||
Comment 6•10 years ago
|
||
*** Original post on bio 1779 at 2012-11-09 23:41:22 UTC *** Comment on attachment 8353836 [details] [diff] [review] (bio-attmnt 2076) Patch I've converted the tabs to spaces, and rephrased the first sentence of the comment to: // If this tab is not currently selected, call the onSelect method of // the current tab to mark the conversation as read before leaving it.
Reporter | ||
Comment 7•10 years ago
|
||
*** Original post on bio 1779 at 2012-11-10 00:22:57 UTC *** http://hg.instantbird.org/instantbird/rev/e0b125ac72a9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•