Closed Bug 955216 Opened 10 years ago Closed 10 years ago

Atheme Nickserv auth success message not recognized when using grouped nicks

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file)

*** Original post on bio 1784 at 2012-11-09 12:11:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1784 as attmnt 2075 at 2012-11-09 12:11:00 UTC ***

12:14:39 PM - flo-retina: I'm on an up to date nightly, and freenode's nickserv still talked to me :(
12:16:16 PM - flo-retina: 12:05:58 - NickServ: This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.
12:16:17 PM - flo-retina: 12:05:58 - NickServ: You are now identified for fqueze_.
12:17:25 PM - flo-retina: we expect nickserv to reply with the current nick
12:17:33 PM - flo-retina: but it doesn't, it uses the first nick of the group
12:17:50 PM - flo-retina: my main freenode nick is fqueze_, and I grouped fqueze into it. I'm currently connected as fqueze.

I don't think we need to check for the nick mentioned in the auth success message, so changing this test should fix things.

Please test as when I log into freenode, it uses SASL and Nickserv is quiet.

Does this mean we can/should reduce the 10s timeout again?
Attachment #8353835 - Flags: review?(florian)
*** Original post on bio 1784 at 2012-11-09 12:32:17 UTC ***

(In reply to comment #0)

> Does this mean we can/should reduce the 10s timeout again?

No, that was completely unrelated (it was for moznet on flaky connections).
Comment on attachment 8353835 [details] [diff] [review]
Patch

*** Original change on bio 1784 attmnt 2075 at 2012-11-09 23:01:02 UTC ***

Works well, thanks!
Attachment #8353835 - Flags: review?(florian) → review+
*** Original post on bio 1784 at 2012-11-10 00:22:26 UTC ***

http://hg.instantbird.org/instantbird/rev/ebce4e225799
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.