Closed
Bug 955238
Opened 10 years ago
Closed 10 years ago
WARNING: no (useful) preprocessor directives found
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
17.36 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1805 at 2012-11-18 00:17:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1805 as attmnt 2096 at 2012-11-18 00:17:00 UTC *** purple/libpurple/purple-prefs.js: WARNING: no preprocessor directives found instantbird/content/credits.xhtml: WARNING: no useful preprocessor directives found instantbird/content/engineManager.js: WARNING: no useful preprocessor directives found instantbird/content/engineManager.xul: WARNING: no useful preprocessor directives found instantbird/content/instantbird.css: WARNING: no preprocessor directives found instantbird/content/instantbird.js: WARNING: no preprocessor directives found instantbird/content/nsContextMenu.js: WARNING: no useful preprocessor directives found instantbird/content/preferences/applications.xul: WARNING: no useful preprocessor directives found instantbird/content/preferences/applicationManager.xul: WARNING: no useful preprocessor directives found instantbird/content/preferences/content.xul: WARNING: no useful preprocessor directives found instantbird/content/preferences/content.js: WARNING: no useful preprocessor directives found instantbird/content/preferences/connection.js: WARNING: no useful preprocessor directives found instantbird/content/preferences/handlers.xml: WARNING: no preprocessor directives found instantbird/content/preferences/handlers.css: WARNING: no preprocessor directives found instantbird/content/preferences/main.js: WARNING: no useful preprocessor directives found instantbird/content/preferences/privacy.xul: WARNING: no useful preprocessor directives found instantbird/content/preferences/privacy.js: WARNING: no preprocessor directives found instantbird/content/preferences/themes.xul: WARNING: no useful preprocessor directives found instantbird/content/preferences/tabs.xul: WARNING: no useful preprocessor directives found instantbird/modules/ibInterruptions.jsm: WARNING: no preprocessor directives found instantbird/modules/ibSounds.jsm: WARNING: no preprocessor directives found The attached patch fixes all these warnings except the one in purple/libpurple/purple-prefs.js (The problem for that file is similar to what's discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=810675).
Attachment #8353857 -
Flags: review?(aleth)
Comment 2•10 years ago
|
||
Comment on attachment 8353857 [details] [diff] [review] Fix *** Original change on bio 1805 attmnt 2096 at 2012-11-18 12:50:43 UTC *** I'm not really the right person to review this, but based on the discussion in the linked mozilla bug it looks good to me, especially as the only changes required were to the comment style ;)
Attachment #8353857 -
Flags: review?(aleth) → review+
Updated•10 years ago
|
OS: Other → All
Hardware: x86 → All
Whiteboard: [checkin-needed]
Comment 3•10 years ago
|
||
*** Original post on bio 1805 at 2012-11-18 18:56:31 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/5286c0725a1f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•