955293 - Bubbles shouldn't call getComputedStyle for each message

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1860 at 2012-12-23 15:07:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch v1

*** Original post on bio 1860 as attmnt 2179 at 2012-12-23 15:07:00 UTC ***

When profiling the display of a large conversation with Bubbles, setColors takes 55% of the total time, and this is because it causes a synchronous reflow for each inserted message by calling getComputedStyle on the new message.

The attached patch caches the result of the first getComputedStyle call, it makes the average total display time for a 11k tweets conversation drop from 68s to 44s on my machine. (setColors is now only 3.4% of the total time.)

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8353941 [details] [diff] [review]
Patch v1

*** Original change on bio 1860 attmnt 2179 at 2012-12-23 15:32:10 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1860 at 2012-12-25 04:47:50 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/bf15064cf956