Closed Bug 955295 Opened 10 years ago Closed 10 years ago

Cleanup Bubbles's CSS

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

*** Original post on bio 1862 at 2012-12-27 22:03:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1862 as attmnt 2181 at 2012-12-27 22:03:00 UTC ***

- Rewrite inefficient CSS rules that have no reason to be written that way.
- Get rid of the <span class="sender"> node that isn't needed now that display: inline-block is supported.
- Use .classList.contains instead of .className.substring
Attachment #8353943 - Flags: review?
*** Original post on bio 1862 at 2012-12-27 22:19:29 UTC ***

Additional change:
diff -u b/instantbird/themes/messages/bubbles/main.css b/instantbird/themes/messages/bubbles/main.css
--- b/instantbird/themes/messages/bubbles/main.css
+++ b/instantbird/themes/messages/bubbles/main.css
@@ -71,7 +71,7 @@
   display: none;
 }
 
-.bubble:hover > .pseudo > .time {
+.bubble:hover > .indicator > .pseudo > .time {
   display: inline;
 }
Comment on attachment 8353943 [details] [diff] [review]
Patch

*** Original change on bio 1862 attmnt 2181 at 2012-12-27 22:22:15 UTC ***

With the additional change, this looks fine.
Attachment #8353943 - Flags: review? → review+
*** Original post on bio 1862 at 2012-12-27 22:24:25 UTC ***

http://hg.instantbird.org/instantbird/rev/21f62a39bcd7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.