Closed Bug 955308 Opened 7 years ago Closed 7 years ago

Rearrange context menu items of conversations on hold

Categories

(Instantbird :: Contacts window, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mic, Assigned: Mic)

Details

Attachments

(1 file)

*** Original post on bio 1875 at 2013-02-11 13:08:00 UTC ***

I'm often confused that the "Close [...]" menuitem of conversations on hold isn't at the bottom of the context menu as it is in many others (e.g. on tabs or on the context menu of task bar items on Windows, ...).

Any objections to move the "Close conversation" to the bottom? "Show conversation" and "Close conversation" will be at the prominent spots at top and bottom then (which is good in my opinion: I can't remember if I ever looked at the logs of a conversation on hold).
Attached patch Patch v1Splinter Review
*** Original post on bio 1875 as attmnt 2227 at 2013-02-11 13:35:00 UTC ***

This patch swaps the order of the "Show logs"- and "Close conversation"-menuitems and adds a separator in between that's conditionally shown.
Attachment #8353990 - Flags: review?(clokep)
Assignee: nobody → benediktp
Comment on attachment 8353990 [details] [diff] [review]
Patch v1

*** Original change on bio 1875 attmnt 2227 at 2013-02-11 23:07:51 UTC ***

This seems to work fine and I think it's a good change!
Attachment #8353990 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1875 at 2013-02-17 12:39:08 UTC ***

http://hg.instantbird.org/instantbird/rev/80cf40b9c923
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.