955309 - Change to use Services.jsm for remaining services where it is available but not used yet

Status: RESOLVED WONTFIX

(Chat Core :: General, enhancement)

Description

[Benedikt Pfeifer]

*** Original post on bio 1876 at 2013-02-16 10:01:00 UTC ***

I think there are a few (not many) services (e.g. appShellService in [1]) for which we could use Service.jsm's lazy getters instead of calling directly or defining our own lazy getters.
A list of available services is here [2], even though checking Services.jsm's code itself might not hurt either.

[1] http://lxr.instantbird.org/instantbird/source/chat/modules/hiddenWindow.jsm
[2] https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Services.jsm

Comment 1

[Benedikt Pfeifer]

Attachment: WIP

*** Original post on bio 1876 as attmnt 2234 at 2013-02-17 15:12:00 UTC ***

I went through the list of interfaces in [2] and replaced them where I thought it was appropriate. I exluded files that we inherited from Firefox/.. like engineManager.js. I thought it might be better in case that we'd ever want to copy changes from their side in to keep these files as intact as possible.

It's a WIP and untested.

Comment 2

[Benedikt Pfeifer]

*** Original post on bio 1876 at 2013-03-08 21:08:38 UTC ***

Some (or all?) work here was done in comm-central and imported to Instantbird already.

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1876 at 2013-03-08 21:22:47 UTC ***

(In reply to comment #2)
> Some (or all?) work here was done in comm-central and imported to Instantbird
> already.

The imported changes only touched chat/, not the instantbird/ part.

Comment 4

[Benedikt Pfeifer]

Mass-removing myself from being assignee of any Chat related bug as I'm no longer active.

Comment 5

[Patrick Cloke [:clokep]]

Instantbird is no longer being developed.