Closed Bug 955313 Opened 10 years ago Closed 10 years ago

Clicking on "status dot" to go Online does not work

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: aleth)

Details

(Whiteboard: [1.4-wanted][regression])

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1880 by Mike Lipscomb <mclipsco AT gmail.com> at 2013-02-21 07:31:00 UTC ***

Click on the status dot on my avatar to go "Offline". Clicking on the gray dot again to go back online does not work or works sporadically. I need to go back online using File > Set status to OR right-click in system tray > Available. 

I am using Debian Squeeze 6.0.6 32-bit, and KDE 4.4.5. Also, I did not install Instantbird, rather I unzipped the .tar.gz file to a folder and run it from the folder.
*** Original post on bio 1880 at 2013-02-21 10:05:05 UTC ***

Thanks for the report. I just tried to reproduce this and there does seem to be a problem when the offline status has focus (recogniseable by the dotted line around the status). Just to check we are seeing the same thing, does this work as a workaround for you: After going offline, click anywhere in the contact list to shift the focus to some other element (for example, click on the display name, or a conversation on hold). Is it now possible to change the status to available? (Note when you switch to "Available", the cursor appears in the status message field to enter a new status. The switch only happens after you press enter or click somewhere outside this textbox.)
Severity: major → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Original post on bio 1880 by Mike Lipscomb <mclipsco AT gmail.com> at 2013-02-21 10:09:50 UTC ***

Yes, this happens exactly as you described above. I noticed this was happening after filing the report but was not certain if it was related or not.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1880 as attmnt 2241 at 2013-02-22 21:37:00 UTC ***

There were a couple of small bugs (some of them regressions) here that overlapped to make the user experience with the mouse less than ideal.
- When the statusMessage has focus but is not editable, the statusTypeIcon does not register click events as the statusMessage "covers" it due to the focusring. (The bug underlying the behaviour described in my earlier comment.) 
- Switching to "available" and then (changing one's mind) switching to "offline" while still editing the message left one with an editbox editing the "Offline" text.
- Clicking on the empty space below the contact list did not work to accept the status message one has entered, as that spacer is not focusable.
Attachment #8354004 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
*** Original post on bio 1880 at 2013-02-22 22:58:28 UTC ***

(In reply to comment #3)
> - When the statusMessage has focus but is not editable
I meant: not in editing mode (with the changed binding).
Whiteboard: [1.4-wanted][regression]
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1880 as attmnt 2402 at 2013-04-22 14:13:00 UTC ***

Fixed paths
Attachment #8354169 - Flags: review?(florian)
Comment on attachment 8354004 [details] [diff] [review]
Patch

*** Original change on bio 1880 attmnt 2241 at 2013-04-22 14:13:13 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354004 - Attachment is obsolete: true
Attachment #8354004 - Flags: review?(florian)
Attached patch PatchSplinter Review
*** Original post on bio 1880 as attmnt 2420 at 2013-04-27 18:32:00 UTC ***

Right and middle mouse buttons do not open the status type popup when the status message is not focused, so they shouldn't open it when the status message has focus either.
Attachment #8354187 - Flags: review?(benediktp)
Comment on attachment 8354169 [details] [diff] [review]
Patch

*** Original change on bio 1880 attmnt 2402 at 2013-04-27 18:32:49 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354169 - Attachment is obsolete: true
Attachment #8354169 - Flags: review?(florian)
Comment on attachment 8354187 [details] [diff] [review]
Patch

*** Original change on bio 1880 attmnt 2420 at 2013-04-27 18:44:41 UTC ***

Thanks!
Attachment #8354187 - Flags: review?(benediktp) → review+
Whiteboard: [1.4-wanted][regression] → [1.4-wanted][regression][checkin-needed]
*** Original post on bio 1880 at 2013-04-27 18:48:44 UTC ***

For the logs: setting the z-index of the status icon (and message label) didn't work reliably, therefore the workaround with the click-event was used. See the conversation following [1].

[1] http://log.bezut.info/instantbird/130427#m273
*** Original post on bio 1880 at 2013-05-21 19:59:24 UTC ***

http://hg.instantbird.org/instantbird/rev/69d9e4f0d1dd

Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.4-wanted][regression][checkin-needed] → [1.4-wanted][regression]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.