Closed
Bug 955318
Opened 10 years ago
Closed 10 years ago
Use unprefixed page visibility API
Categories
(Instantbird Graveyard :: Other, enhancement)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: benediktp, Assigned: benediktp)
References
Details
Attachments
(1 file)
1.58 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1884 at 2013-02-28 09:44:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1884 as attmnt 2246 at 2013-02-28 09:44:00 UTC *** Mozilla 18 supports the unprefixed page visibility API. At the moment the Bubbles theme is the only user of this API and still has the moz-prefixes set on it. The attached patch removes the prefixes. See https://developer.mozilla.org/en-US/docs/DOM/Using_the_Page_Visibility_API
Attachment #8354010 -
Flags: review?(clokep)
Updated•10 years ago
|
Comment 2•10 years ago
|
||
Comment on attachment 8354010 [details] [diff] [review] Patch *** Original change on bio 1884 attmnt 2246 at 2013-02-28 11:31:25 UTC *** This looks fine, I didn't actually try this though: I assume you have.
Attachment #8354010 -
Flags: review?(clokep) → review+
Comment 3•10 years ago
|
||
*** Original post on bio 1884 at 2013-02-28 11:31:55 UTC *** Assigning.
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Whiteboard: [checkin-needed]
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1884 at 2013-02-28 20:49:20 UTC *** Define "tried". I've used Instantbird (and the "Bubble" theme of course!) with the patch applied for a while and didn't notice anything wrong.
Comment 5•10 years ago
|
||
*** Original post on bio 1884 at 2013-02-28 20:50:56 UTC *** (In reply to comment #3) > Define "tried". I've used Instantbird (and the "Bubble" theme of course!) with > the patch applied for a while and didn't notice anything wrong. That counts as tried. :) Thanks!
Comment 6•10 years ago
|
||
*** Original post on bio 1884 at 2013-02-28 23:44:50 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/90c604c78f80 Thanks for the clean up!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•