95532 - In embedding projects, add triggering PSM init during startup

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[(Don't use, old account) - Kai Engert]

See bug 76915 for the background. Basically, if there is the risk of having no
write access or a full disk, one should make sure during init that PSM can init
properly.

Some comments from an off-bugzilla discussion:


If we're initializing it explictly, and doing things to nsAppRunner.cpp, don't
forget about embedding. If the
initialization was removed from nsGlobalWindowImpl and into nsAppRunner.cpp,
embedding apps would be in a world
of hurt. Something similar would have to be done in NS_InitEmbedding().

Conrad Carlen wrote:
> 
> > Kai Engert wrote:
> >
> >> Regarding NS_InitEmbedding I'd be glad to get some help. Can you
> >> tell me
> >> at which place I should add the call, and what service/code should
> >> I
> >> call to display the error? Can I expect the error file to be
> >> available
> >> as it is in the non-embedding case, or do we need to do something
> >> completely different?
> >>
> This error is first detected in nsNSSComponent.cpp here:
> 
> +  if (NSS_InitReadWrite(profileStr) != SECSuccess) {
> 
> right? If that's true, the initialization and error check can't be in
> NS_InitEmbedding because, at that point, the profile has not been set.
> I think that embedding apps may have to handle this check themselves
> :-/

Comment 1

[(Don't use, old account) - Kai Engert]

Changing my prefered e-mail address.

Comment 2

[John Unruh]

QA > junruh

Comment 3

[Kai Engert (:KaiE:)]

If the patch for bug 75947 gets accepted, this bug will become obsolete.

Comment 4

[John Unruh]

Marking fixed per kaie's comment.

Comment 5

[John Unruh]

Verified.