Closed Bug 955320 Opened 10 years ago Closed 10 years ago

The topic of a Twitter timeline disappears if you close the conversation

Categories

(Chat Core :: Twitter, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file)

*** Original post on bio 1886 at 2013-03-03 21:42:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1886 as attmnt 2254 at 2013-03-03 21:42:00 UTC ***

If you close the Twitter timeline, when it reopens the topic is never set.

Also, do we never normalize Twitter names anywhere (which is just toLowerCase for Twitter), but it would seem like the keys should be case insensitive?
Attachment #8354018 - Flags: review?(aleth)
Comment on attachment 8354018 [details] [diff] [review]
Patch

*** Original change on bio 1886 attmnt 2254 at 2013-03-04 11:59:06 UTC ***

+    if (hasOwnProperty(userInfo, "description"))
You could use 
 if ("description" in userInfo)
here, but that's such a small nit I'll leave it up to you if you want to change it.

>Also, do we never normalize Twitter names anywhere (which is just toLowerCase
>for Twitter), but it would seem like the keys should be case insensitive?
As far as I know, most twitter API calls are case insensitive about the screen name, but the screen name itself has a specific case. Some calls (eg account/update_profile) are case sensitive, but I couldn't find a list of these. I guess as long as we always take the screen names provided by twitter (as opposed to user input) we should be fine.
Attachment #8354018 - Flags: review?(aleth) → review+
*** Original post on bio 1886 at 2013-03-04 12:02:15 UTC ***

(In reply to comment #1)
> +    if (hasOwnProperty(userInfo, "description"))
> You could use 
>  if ("description" in userInfo)
> here, but that's such a small nit I'll leave it up to you if you want to change
> it.
I don't have a strong opinion either way.

> >Also, do we never normalize Twitter names anywhere (which is just toLowerCase
> >for Twitter), but it would seem like the keys should be case insensitive?
> As far as I know, most twitter API calls are case insensitive about the screen
> name, but the screen name itself has a specific case. Some calls (eg
> account/update_profile) are case sensitive, but I couldn't find a list of
> these.
I'm not concerned with giving them to the Twitter API, I'm concerned about using them internally.

> I guess as long as we always take the screen names provided by twitter
> (as opposed to user input) we should be fine.
This patch compares something returned by Twitter to the account name the user typed in, do we ever update the capitalization of the account name property?
*** Original post on bio 1886 at 2013-03-04 12:33:01 UTC ***

(In reply to comment #2)
>I'm not concerned with giving them to the Twitter API, I'm concerned about
>using them internally.
Right, we should normalize whenever we compare user input to screen names.

> > I guess as long as we always take the screen names provided by twitter
> > (as opposed to user input) we should be fine.
> This patch compares something returned by Twitter to the account name the user
> typed in, do we ever update the capitalization of the account name property?
Given that account/update_profile is case sensitive regarding the user account screen name, is the auth procedure itself not case sensitive? (I had assumed it was, but I don't know.)
*** Original post on bio 1886 at 2013-03-04 13:12:27 UTC ***

(In reply to comment #3)
> Given that account/update_profile is case sensitive regarding the user account
> screen name, is the auth procedure itself not case sensitive? (I had assumed it
> was, but I don't know.)
I just checked and neither update_profile nor the auth during login seems to be screen name case sensitive anymore. So we should check how we handle this.
Whiteboard: [checkin-needed]
*** Original post on bio 1886 at 2013-03-05 00:09:21 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/793ee727237c (with the change to "description" in userInfo).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.