Closed Bug 955340 Opened 10 years ago Closed 10 years ago

Changing the selected account with the up/down arrow keys works only once

Categories

(Instantbird Graveyard :: Account manager, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

*** Original post on bio 1904 at 2013-03-21 23:40:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 1904 as attmnt 2293 at 2013-03-21 23:40:00 UTC ***

After selecting the next account, the focus is lost, and pressing an arrow key again does nothing.

Bug 953624 (bio 177) and bug 953626 (bio 179) added poor hacks (a setTimeout AND a try/catch!) to work around the fact that the XBL binding of a selected account wasn't attached yet at the time the code runs.

We can just force the layout to force synchronous binding attachment...
Attachment #8354058 - Flags: review?
Blocks: 953624, 953626
Comment on attachment 8354058 [details] [diff] [review]
Patch

*** Original change on bio 1904 attmnt 2293 at 2013-03-21 23:57:09 UTC ***

Works like a charm, thanks for fixing this long-standing bug (see bug 953994 (bio 557))! 

"// force binding attachment" sounds a little strange for me, is that what you wanted to write?
Attachment #8354058 - Flags: review? → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1904 at 2013-03-22 08:18:40 UTC ***

https://hg.instantbird.org/instantbird/rev/cc4c3682aa17
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Assignee: nobody → florian
Target Milestone: --- → 1.4
Depends on: 955345
You need to log in before you can comment on or make changes to this bug.