Add hidden option to allow using Facebook beta server

RESOLVED FIXED in 1.4

Status

Chat Core
XMPP
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
*** Original post on bio 1927 at 2013-04-13 15:43:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
(Assignee)

Comment 1

5 years ago
Created attachment 8354121 [details] [diff] [review]
(Untested) patch v1

*** Original post on bio 1927 as attmnt 2354 at 2013-04-13 15:43:00 UTC ***

I've wanted to start using the beta Facebook chat server to ensure we don't break with any changes coming down the line from them. Currently I'd have to create an extension or hack my Instantbird install to do this, it seems fairly trivial to add a hidden (about:config) option to use their beta server.

My patch is currently untested, I'll request review once I test it.
(Assignee)

Comment 2

5 years ago
*** Original post on bio 1927 at 2013-04-13 15:44:42 UTC ***

Assigning.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
*** Original post on bio 1927 at 2013-04-13 21:27:35 UTC ***

Would it be better if the pref was a char pref containing the hostname to connect to? (In case the name of the beta server changes, or whatever...)

Just my 2 cents, I don't mind either way.
(Assignee)

Comment 4

5 years ago
Created attachment 8354132 [details] [diff] [review]
Patch v2

*** Original post on bio 1927 as attmnt 2365 at 2013-04-16 01:31:00 UTC ***

Actually, we already have a "server" pref for normal XMPP, it probably makes sense to use the same thing.
Attachment #8354132 - Flags: review?(florian)
(Assignee)

Comment 5

5 years ago
Comment on attachment 8354121 [details] [diff] [review]
(Untested) patch v1

*** Original change on bio 1927 attmnt 2354 at 2013-04-16 01:31:40 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354121 - Attachment is obsolete: true
Comment on attachment 8354132 [details] [diff] [review]
Patch v2

*** Original change on bio 1927 attmnt 2365 at 2013-04-16 10:41:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354132 - Flags: review?(florian) → review+
(Assignee)

Comment 7

5 years ago
*** Original post on bio 1927 at 2013-04-16 23:25:33 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/1c6b7e0316e1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.