95537 - Create fwToken->mdObjectHash twice in functions nssCKFWToken_Create,that's not right.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[zhoubin]

source code:

  fwToken->mdObjectHash = nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->mdObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

  fwToken->mdObjectHash = nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->mdObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

Comment 1

[zhoubin]

Modify as:

  fwToken->mdObjectHash = nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->mdObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

  fwToken->sessionObjectHash= nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->mdObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

Comment 2

[Wan-Teh Chang]

Hi,

There seems to be a typo in your modified version.  Should it be
the following?

  fwToken->mdObjectHash = nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->mdObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

  fwToken->sessionObjectHash= nssCKFWHash_Create(fwToken->fwInstance, 
                            arena, pError);
  if( (nssCKFWHash *)NULL == fwToken->sessionObjectHash ) {
    if( CKR_OK == *pError ) {
      *pError = CKR_GENERAL_ERROR;
    }
    goto loser;
  }

Bob, could you take a look at this patch?  Is Zhou Bin's patch
correct or should we simply delete the redundant creation of
fwToken->mdObjectHash?

Comment 3

[Keyser Sose]

Marking NEW.

Comment 4

[Robert Relyea]

We delete the redundant call. fwToken->sessionObjectHash is set in the previous
statement (and set only if the base module does not handle sessionObjects on
it's own).