955371 - Improve the two "weekly" group strings in the log viewer

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1933 at 2013-04-15 10:45:00 UTC ***

Last week -> This week
Two weeks ago -> Last week

or ...?

I'll upload a patch quickly (as string freeze is imminent) if everyone agrees with this. (I'm a bit confused that someone for TB thought it was obvious that Last week would refer to the past 7 days.)

Comment 1

[aleth [:aleth]]

*** Original post on bio 1933 at 2013-04-15 11:01:14 UTC ***

Since "weeks" run Sunday-Saturday or Monday-Sunday, would "Last %S days" be better (for %S = 7 and 14 respectively)?

Comment 2

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1933 as attmnt 2362 at 2013-04-15 12:09:00 UTC ***

Used currentWeek/previousWeek for the strings to avoid confusion with the strings in TB.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8354129 [details] [diff] [review]
Patch

*** Original change on bio 1933 attmnt 2362 at 2013-04-15 12:15:40 UTC ***

For another data point, this matches how outlook organizes my email.

I do wonder whether we should actually group these into logical weeks instead of rolling days, but that's probably a separate debate.

Comment 4

[aleth [:aleth]]

*** Original post on bio 1933 at 2013-04-15 12:17:52 UTC ***

Actual weeks may in fact be better, but not essential for 1.4 ;)

Thanks for the quick review!


Checkin note: Context depends on the patch for bug 955363 (bio 1926) which should be checked in first.

Comment 5

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1933 as attmnt 2379 at 2013-04-17 11:12:00 UTC ***

Rebased for immediate checkin

Comment 6

[aleth [:aleth]]

Comment on attachment 8354129 [details] [diff] [review]
Patch

*** Original change on bio 1933 attmnt 2362 at 2013-04-17 11:12:21 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[Patrick Cloke [:clokep]]

*** Original post on bio 1933 at 2013-04-17 23:02:17 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/42f084658d51

Thanks!