Closed
Bug 955371
Opened 10 years ago
Closed 10 years ago
Improve the two "weekly" group strings in the log viewer
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: aleth, Assigned: aleth)
Details
(Whiteboard: [1.4-wanted])
Attachments
(1 file, 1 obsolete file)
3.25 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1933 at 2013-04-15 10:45:00 UTC *** Last week -> This week Two weeks ago -> Last week or ...? I'll upload a patch quickly (as string freeze is imminent) if everyone agrees with this. (I'm a bit confused that someone for TB thought it was obvious that Last week would refer to the past 7 days.)
Assignee | ||
Updated•10 years ago
|
Severity: normal → trivial
Whiteboard: [1.4-wanted]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1933 at 2013-04-15 11:01:14 UTC *** Since "weeks" run Sunday-Saturday or Monday-Sunday, would "Last %S days" be better (for %S = 7 and 14 respectively)?
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1933 as attmnt 2362 at 2013-04-15 12:09:00 UTC *** Used currentWeek/previousWeek for the strings to avoid confusion with the strings in TB.
Attachment #8354129 -
Flags: review?(clokep)
Comment 3•10 years ago
|
||
Comment on attachment 8354129 [details] [diff] [review] Patch *** Original change on bio 1933 attmnt 2362 at 2013-04-15 12:15:40 UTC *** For another data point, this matches how outlook organizes my email. I do wonder whether we should actually group these into logical weeks instead of rolling days, but that's probably a separate debate.
Attachment #8354129 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1933 at 2013-04-15 12:17:52 UTC *** Actual weeks may in fact be better, but not essential for 1.4 ;) Thanks for the quick review! Checkin note: Context depends on the patch for bug 955363 (bio 1926) which should be checked in first.
Whiteboard: [1.4-wanted] → [1.4-wanted][checkin-needed]
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1933 as attmnt 2379 at 2013-04-17 11:12:00 UTC *** Rebased for immediate checkin
Attachment #8354146 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8354129 [details] [diff] [review] Patch *** Original change on bio 1933 attmnt 2362 at 2013-04-17 11:12:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354129 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
*** Original post on bio 1933 at 2013-04-17 23:02:17 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/42f084658d51 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.4-wanted][checkin-needed] → [1.4-wanted]
Target Milestone: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•