Closed Bug 955372 Opened 7 years ago Closed 7 years ago

Make max message length for IRC smarter

Categories

(Chat Core :: IRC, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: aleth)

References

Details

Attachments

(1 file)

*** Original post on bio 1934 at 2013-04-15 23:40:00 UTC ***

(In reply to bug 954484 (bio 1050) comment #12)
> I'd prefer to handle the IRC case in a follow up. Florian provided the
> following to use the length of the longest line:
> Math.max.apply(null, aString.split("\n").map(this._account.countBytes))
Depends on: 954484
Attached patch PatchSplinter Review
*** Original post on bio 1934 as attmnt 2368 at 2013-04-16 13:49:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354135 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354135 [details] [diff] [review]
Patch

*** Original change on bio 1934 attmnt 2368 at 2013-04-16 14:08:35 UTC ***

Looks good.
Attachment #8354135 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1934 at 2013-04-16 23:24:33 UTC ***

http://hg.instantbird.org/instantbird/rev/036fe377995e

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
Depends on: 955377
You need to log in before you can comment on or make changes to this bug.