Closed
Bug 955381
Opened 10 years ago
Closed 10 years ago
irc.js should use lazy getters for localized strings
Categories
(Chat Core :: IRC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
2.64 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1943 at 2013-04-20 19:55:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1943 as attmnt 2395 at 2013-04-20 19:55:00 UTC *** These strings are fetched when parsing irc.js and kept in memory all the time instead of being fetched when they are used: "_Channel" "_Password" "Character Set" "Quit message" "Part message" "Server" "Port" "Use SSL" "Show messages from the server" Other JS-prpls use lazy getters for this. (Completely untested patch, but I'll test it before landing if it's r+'ed.)
Attachment #8354162 -
Flags: review?(clokep)
Comment 2•10 years ago
|
||
Comment on attachment 8354162 [details] [diff] [review] Patch *** Original change on bio 1943 attmnt 2395 at 2013-04-21 05:26:07 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354162 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1943 at 2013-04-24 04:38:32 UTC *** http://hg.instantbird.org/instantbird/rev/0edc579572c0
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•