955392 - Broken complete mar files generated during l10n repack

Status: RESOLVED FIXED

(Instantbird Graveyard :: Localization, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1954 at 2013-05-06 13:19:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 1954 as attmnt 2427 at 2013-05-06 13:19:00 UTC ***

The attached patch merges the changes from mail/locales/Makefiles.in to instantbird/locales/Makefiles.in, the changes that seemed related in config/config.mk, and adds a define in build.mk.

I'm marking a dependency on the Mozilla 20 update bug, but it could really be any Moz update since 1.3 that broke this...

Comment 2

[Quentin Raynaud]

Comment on attachment 8354194 [details] [diff] [review]
Patch

*** Original change on bio 1954 attmnt 2427 at 2013-05-06 13:27:02 UTC ***

Looks good to me.

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1954 at 2013-05-06 13:34:02 UTC ***

http://hg.instantbird.org/instantbird/rev/5fdd543f3e26 - 1.4 branch
http://hg.instantbird.org/instantbird/rev/71f11f2e226f - default branch.

Comment 4

[Florian Quèze [:florian]]

Attachment: Follow-up to fix l10n repackaging of Mac universal builds

*** Original post on bio 1954 as attmnt 2431 at 2013-05-15 23:22:00 UTC ***

Revert a change that I shouldn't have made in the previous patch; this fixes the l10n repack of Mac universal builds.

Comment 5

[Quentin Raynaud]

Attachment: Follow up to fix win32 installer l10n repackaging

*** Original post on bio 1954 as attmnt 2435 at 2013-05-16 20:29:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Quentin Raynaud]

Comment on attachment 8354198 [details] [diff] [review]
Follow-up to fix l10n repackaging of Mac universal builds

*** Original change on bio 1954 attmnt 2431 at 2013-05-16 20:30:21 UTC ***

Looks good to me.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8354202 [details] [diff] [review]
Follow up to fix win32 installer l10n repackaging

*** Original change on bio 1954 attmnt 2435 at 2013-05-16 20:31:13 UTC ***

We pair-programmed on this, r=me.

Comment 8

[Patrick Cloke [:clokep]]

*** Original post on bio 1954 at 2013-05-16 23:03:08 UTC ***

1.4 branch:
http://hg.instantbird.org/instantbird/rev/d7dad56f3a8b
http://hg.instantbird.org/instantbird/rev/9cfcfa4bad1d

default branch (trunk):
http://hg.instantbird.org/instantbird/rev/10cbf5987746
http://hg.instantbird.org/instantbird/rev/c48944871230

Thanks for figuring this out!