Closed Bug 955416 Opened 10 years ago Closed 10 years ago

"Typing" indicator is never cleared.

Categories

(Chat Core :: XMPP, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: nhnt11, Assigned: florian)

References

Details

Attachments

(2 files)

*** Original post on bio 1979 at 2013-05-26 20:05:00 UTC ***

Since Google Hangouts released, the "xxxx is typing." and "xxxx has stopped typing." indicators are never cleared.

Here are the results of a quick diagnostic session with a friend:

1. If he starts typing and then sends the message, "xxxx is typing." remains.
2. If he starts typing and stops, it changes to "xxxx has stopped typing." After this, if he sends the message without further modification, "xxxx has stopped typing." remains until he starts typing again. If he modifies the typed message and sends, it gets stuck at "xxxx is typing."

Based solely on this, I think that simply clearing the "typing" status after a new message is received would be enough to fix this bug.
*** Original post on bio 1979 at 2013-05-26 20:09:25 UTC ***

May be a dupe of bug 955085 (bio 1656), but I think that only deals with when a buddy goes offline. I've been seeing this only since Google Hangouts released and not just when a buddy goes offline. Probably should mark as duplicate though, sorry for missing it when I searched.
*** Original post on bio 1979 at 2013-05-27 01:54:29 UTC ***

I'm PRETTY sure this is a Google bug and not a bug in our code, but if we can minimize it...that'd be great. :)
*** Original post on bio 1979 as attmnt 2493 at 2013-06-18 12:58:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attached patch PatchSplinter Review
*** Original post on bio 1979 as attmnt 2549 at 2013-07-03 13:36:00 UTC ***

So the google servers send us the <message> stanza containing the body from the full JID but without chatstates, and then a stanza from the bare JID with the 'inactive' state (that we don't currently support). I don't think it's standard behavior, but hopefully the attached patch will handle it while still respecting the spec.

I haven't tested this at all, so I would appreciate if someone could test it before we check it in!
Attachment #8354317 - Flags: review?(clokep)
Assignee: nobody → florian
Comment on attachment 8354317 [details] [diff] [review]
Patch

*** Original change on bio 1979 attmnt 2549 at 2013-07-10 23:53:54 UTC ***

The changes look fine, I have not tested this, but Florian believes qheaden or nhnt11 have.
Attachment #8354317 - Flags: review?(clokep) → review+
*** Original post on bio 1979 at 2013-07-11 01:19:54 UTC ***

Checked-in as http://hg.instantbird.org/instantbird/rev/d3ef4210bb73

Please reopen this if it doesn't fix the problem.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
*** Original post on bio 1979 at 2013-07-12 20:20:46 UTC ***

I verified this with a friend on Hangouts.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.