Closed
Bug 955417
Opened 10 years ago
Closed 10 years ago
In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols
Categories
(Chat Core :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: bugzilla, Assigned: clokep)
Details
Attachments
(2 files)
4.09 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
1.36 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1980 by S.Iaroshenko <iaroshenko AT gmail.com> at 2013-05-29 12:20:00 UTC *** 1. Open properties for existing IRC account 2. In Auto-Joined Channels field, put a non-ASCII channel name (let's say, #помощь ) 3. Press OK 4. Reopen IRC account properties Expected: channel name will be the same In Fact: channel name is corrupted, showing #?><>IL instead. As a result, auto-join on non-ASCII channels doesn't work
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1980 at 2013-05-29 12:23:30 UTC *** Confirming. I'm guessing these get saved as normal strings right now in the pref system and we need to use something like [1]. [1] http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#154
Status: UNCONFIRMED → NEW
Component: Localization → General
Ever confirmed: true
Product: Instantbird → Chat Core
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1980 as attmnt 2478 at 2013-06-10 22:02:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354245 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8354245 [details] [diff] [review] Fix *** Original change on bio 1980 attmnt 2478 at 2013-06-10 22:14:03 UTC *** Thanks!
Attachment #8354245 -
Flags: review?(florian) → review+
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1980 at 2013-06-10 22:54:39 UTC *** Checked-in as http://hg.instantbird.org/instantbird/rev/b9a7cb74952e Thanks for reporting this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1980 as attmnt 2932 at 2013-10-09 12:36:00 UTC *** When looking to port this to c-c I realized that the fix wasn't done for the join chat dialog.
Attachment #8354706 -
Flags: review?(florian)
Comment 6•10 years ago
|
||
Comment on attachment 8354706 [details] [diff] [review] Fix for join chat dialog *** Original change on bio 1980 attmnt 2932 at 2013-10-09 12:44:08 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354706 -
Flags: review?(florian) → review+
Assignee | ||
Comment 7•10 years ago
|
||
*** Original post on bio 1980 at 2013-10-09 12:54:39 UTC *** http://hg.instantbird.org/instantbird/rev/c7587a9e2f68 Thanks for the quick review.
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 1980 at 2013-10-14 22:11:23 UTC *** And another fix from a typo: http://hg.instantbird.org/instantbird/rev/8d8cf40afa6d
You need to log in
before you can comment on or make changes to this bug.
Description
•