Closed
Bug 955456
Opened 10 years ago
Closed 10 years ago
JS-strict warnings in tabbrowser.xml
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file)
2.18 KB,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2019 at 2013-06-27 11:05:00 UTC *** Timestamp: 06/27/2013 11:21:07 AM Warning: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function Source File: chrome://instantbird/content/tabbrowser.xml Line: 1985, Column: 21 Source Code: function enableDblClick(event) { Timestamp: 06/27/2013 01:03:23 PM Warning: in strict mode code, functions may be declared only at top level or immediately within another function Source File: chrome://instantbird/content/tabbrowser.xml Line: 664, Column: 23 Source Code: function _delayedUpdate(aTabContainer) { It's probably enough to do let enableDblClick = function (event) ...
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2019 as attmnt 2522 at 2013-06-27 14:17:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354290 -
Flags: review?(nhnt11)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8354290 [details] [diff] [review] Patch *** Original change on bio 2019 attmnt 2522 at 2013-06-27 15:04:07 UTC *** Looks good to me.
Attachment #8354290 -
Flags: review?(nhnt11) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 3•10 years ago
|
||
*** Original post on bio 2019 at 2013-06-27 23:47:00 UTC *** http://hg.instantbird.org/instantbird/rev/ac63d193619c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•