Closed Bug 955472 Opened 8 years ago Closed 8 years ago

Tabbrowser tab needs an attribute that tells CSS what kind of tab it is.

Categories

(Instantbird :: Conversation, enhancement)

x86
Other
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 2035 at 2013-07-10 09:13:00 UTC ***

This way we can easily select specific tabs. A possible use case (and the reason for filing this bug) is so that tab icons can easily be set from CSS.
Attached patch Add tabtype attribute (obsolete) — Splinter Review
*** Original post on bio 2035 as attmnt 2563 at 2013-07-10 09:27:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354331 - Flags: review?(benediktp)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Blocks: 955452
*** Original post on bio 2035 as attmnt 2565 at 2013-07-10 12:52:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354333 - Flags: review?(florian)
Attachment #8354333 - Flags: review?(benediktp)
Comment on attachment 8354331 [details] [diff] [review]
Add tabtype attribute

*** Original change on bio 2035 attmnt 2563 at 2013-07-10 12:52:53 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354331 - Attachment is obsolete: true
Attachment #8354331 - Flags: review?(benediktp)
Attached patch Adapt existing stuff to use this (obsolete) — Splinter Review
*** Original post on bio 2035 as attmnt 2567 at 2013-07-10 13:43:00 UTC ***

This makes tabs use the Firefox newtab icon by default, and sets the "Unknown" question mark icon for conversation tabs separately. Also adapts the aboutPanel code accordingly.
Attachment #8354335 - Flags: review?(florian)
Comment on attachment 8354333 [details] [diff] [review]
Change name of attribute to just "type"

*** Original change on bio 2035 attmnt 2565 at 2013-07-10 13:43:51 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354333 - Attachment is obsolete: true
Attachment #8354333 - Flags: review?(florian)
Attachment #8354333 - Flags: review?(benediktp)
*** Original post on bio 2035 as attmnt 2568 at 2013-07-10 14:08:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354336 - Flags: review?(florian)
Comment on attachment 8354335 [details] [diff] [review]
Adapt existing stuff to use this

*** Original change on bio 2035 attmnt 2567 at 2013-07-10 14:08:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354335 - Attachment is obsolete: true
Attachment #8354335 - Flags: review?(florian)
Comment on attachment 8354336 [details] [diff] [review]
Set addons page favicon from CSS

*** Original change on bio 2035 attmnt 2568 at 2013-07-10 15:02:59 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354336 - Flags: review?(florian) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2035 at 2013-07-11 23:56:04 UTC ***

http://hg.instantbird.org/instantbird/rev/3aae8b5d40c9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.