Closed Bug 955481 Opened 10 years ago Closed 10 years ago

Use standard colours for richlistbox on Linux

Categories

(Instantbird Graveyard :: Other, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(4 files, 4 obsolete files)

*** Original post on bio 2044 at 2013-07-12 10:36:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 955452
Attached image Screenshot (obsolete) —
*** Original post on bio 2044 as attmnt 2580 at 2013-07-12 10:36:00 UTC ***

The font sizes and the spacing/alignment seems wrong.
*** Original post on bio 2044 at 2013-07-12 11:37:09 UTC ***

Also, the selected item is gray for some reason?
*** Original post on bio 2044 at 2013-07-12 12:29:42 UTC ***

Filterbar background should be white. (This is probably a more general CSS error actually as similar textboxes in the error console also have this problem.)
Attached image Screenshot (obsolete) —
*** Original post on bio 2044 as attmnt 2598 at 2013-07-15 14:50:00 UTC ***

I discovered most of issues with the listitems were due to an add-on that modified the displayName class.
Comment on attachment 8354348 [details]
Screenshot

*** Original change on bio 2044 attmnt 2580 at 2013-07-15 14:50:36 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354348 - Attachment is obsolete: true
*** Original post on bio 2044 at 2013-07-15 14:53:58 UTC ***

It's possible that comment 1 or 2 are due to the lack of 64bit builds (which does cause some problems with GTK theming on 64bit systems), if someone could confirm that it looks OK on 32bit (or not) that would be helpful.
*** Original post on bio 2044 at 2013-07-16 13:27:00 UTC ***

(In reply to comment #1)
> Also, the selected item is gray for some reason?

This is due to the rule in the IB richlistbox.css for Linux.
*** Original post on bio 2044 as attmnt 2637 at 2013-07-25 14:47:00 UTC ***

For Linux, this removes the CSS in richlistbox.css which overrides the default listitem colours, and adds the CSS (currently OSX-only) which shades alternating rows. We should try this in nightlies so people on various Linux themes can give their feedback, but it seems an improvement to me (also for the account manager).
Attachment #8354406 - Flags: review?(clokep)
*** Original post on bio 2044 at 2013-07-25 14:49:01 UTC ***

(In reply to comment #6)
> Created attachment 8354406 [details] [diff] [review] (bio-attmnt 2637) [details]
> Improve richlistbox styling for Linux
> 
> For Linux, this removes the CSS in richlistbox.css which overrides the default
> listitem colours, and adds the CSS (currently OSX-only) which shades
> alternating rows. We should try this in nightlies so people on various Linux
> themes can give their feedback, but it seems an improvement to me (also for the
> account manager).

Can I get a screenshot with the changes?
Attached image Screenshot with richlistbox changes (obsolete) —
*** Original post on bio 2044 as attmnt 2638 at 2013-07-25 14:53:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Summary: New tab item styling not optimal on Linux → New tab styling not optimal on Linux
Comment on attachment 8354406 [details] [diff] [review]
Improve richlistbox styling for Linux

*** Original change on bio 2044 attmnt 2637 at 2013-07-25 15:04:43 UTC ***

This change looks OK for me. I'm going to let Florian take a look at it first since it's UI though. I'd like to know why we don't want alternating rows on Windows though.
Attachment #8354406 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2044 as attmnt 2639 at 2013-07-25 15:19:00 UTC ***

Though I do wonder if we should turn off the dotted line border if we use alternating background colours on Linux (see screenshot). Hopefully trying the current patch in nightlies will help (as we'll get feedback from people using different themes).
*** Original post on bio 2044 as attmnt 2640 at 2013-07-25 15:41:00 UTC ***

I just realized the purpose of the richlistitem[selected="true"]:not(:-moz-window-inactive) rule for Windows and OSX: It ensures that when keyboard-tabbing through the buttons of a selected item in the account manager the background colour of the selected listitem does not change due to its loss of focus. This means the same rule should be applied for Linux too. (No other changes)
Attachment #8354409 - Flags: review?(clokep)
Comment on attachment 8354407 [details]
Screenshot with richlistbox changes

*** Original change on bio 2044 attmnt 2638 at 2013-07-25 15:41:55 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354407 - Attachment is obsolete: true
*** Original post on bio 2044 as attmnt 2641 at 2013-07-25 15:44:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8354409 [details] [diff] [review]
Patch with correct focus behaviour in the account manager

*** Original change on bio 2044 attmnt 2640 at 2013-07-25 15:44:07 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354409 - Attachment is obsolete: true
Attachment #8354409 - Flags: review?(clokep)
Comment on attachment 8354409 [details] [diff] [review]
Patch with correct focus behaviour in the account manager

*** Original change on bio 2044 attmnt 2640 at 2013-07-25 15:45:59 UTC ***

Not sure why the new patch got marked as obsolete.
Attachment #8354409 - Attachment is obsolete: false
Attachment #8354409 - Flags: review?(clokep)
Comment on attachment 8354406 [details] [diff] [review]
Improve richlistbox styling for Linux

*** Original change on bio 2044 attmnt 2637 at 2013-07-25 15:46:29 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354406 - Attachment is obsolete: true
*** Original post on bio 2044 as attmnt 2642 at 2013-07-25 16:36:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8354367 [details]
Screenshot

*** Original change on bio 2044 attmnt 2598 at 2013-07-25 16:36:53 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354367 - Attachment is obsolete: true
Comment on attachment 8354409 [details] [diff] [review]
Patch with correct focus behaviour in the account manager

*** Original change on bio 2044 attmnt 2640 at 2013-07-26 10:50:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354409 - Flags: review?(clokep) → review+
*** Original post on bio 2044 at 2013-07-26 10:55:04 UTC ***

http://hg.instantbird.org/instantbird/rev/a8f33e9a8f48
Assignee: nobody → aleth
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
*** Original post on bio 2044 at 2013-07-26 10:58:21 UTC ***

Retitling this and filing new bugs for what is left to do.
Summary: New tab styling not optimal on Linux → Use standard colours for richlistbox on Linux
You need to log in before you can comment on or make changes to this bug.