Closed
Bug 955482
Opened 10 years ago
Closed 10 years ago
Update theming of the "+" buttons on OS X
Categories
(Instantbird Graveyard :: Conversation, defect)
Instantbird Graveyard
Conversation
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: clokep, Assigned: nhnt11)
References
Details
Attachments
(2 files, 1 obsolete file)
38.52 KB,
image/png
|
Details | |
10.43 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2045 at 2013-07-12 10:58:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Reporter | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2045 as attmnt 2581 at 2013-07-12 10:58:00 UTC *** The new tab button stops looking like a button and becomes flat, etc. This might be Windows only.
Comment 2•10 years ago
|
||
*** Original post on bio 2045 at 2013-07-12 10:59:44 UTC *** Can't reproduce on Linux.
Comment 3•10 years ago
|
||
*** Original post on bio 2045 at 2013-07-12 11:06:52 UTC *** This button also has theming issues on Mac. Both in overflow and non-overflow cases. My guess is that we got these themed like in Firefox 3.6, then updated our tabs theming but didn't update the rules related to these buttons as they were hidden.
OS: Windows 7 → All
Hardware: x86 → All
Summary: New tab button broken when tabs start scrolling → Update theming of the "+" buttons
Comment 4•10 years ago
|
||
*** Original post on bio 2045 at 2013-07-12 11:08:27 UTC *** I'm not sure the /theming/ of the + button is complete for Linux either.
Comment 5•10 years ago
|
||
*** Original post on bio 2045 at 2013-07-12 16:29:46 UTC *** I'd say that the button should have the flat look like the other two flat buttons that it sits between (i.e. the scroll button for the tab strip and the all tabs-menu). It certainly shouldn't have *this* look though ;)
Assignee | ||
Comment 6•10 years ago
|
||
*** Original post on bio 2045 as attmnt 2618 at 2013-07-20 21:28:00 UTC *** Also adds the @2x icon for newtab.png
Attachment #8354387 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment 7•10 years ago
|
||
Comment on attachment 8354387 [details] [diff] [review] Fix for Mac *** Original change on bio 2045 attmnt 2618 at 2013-07-20 23:11:26 UTC *** > skin/classic/instantbird/tabbrowser/newtab.png (tabbrowser-pinstripe/newtab.png) >+ skin/classic/instantbird/tabbrowser/newtab@2x.png (tabbrowser-pinstripe/newtab@2x.png) Nit: fix alignment. >+:not(.tabbrowser-arrowscrollbox) > .tabs-newtab-button:hover { Per IRC discussion, we prefer .tabs-container instead of :not(.tabbrowser-arrowscrollbox) >+:not(.tabbrowser-arrowscrollbox) > .tabs-newtab-button:active { Here too. >+:not(.tabbrowser-arrowscrollbox) > .tabs-newtab-button { And here. >+ padding: 2px 0 2px; Can be simplified to: padding: 2px 0;
Attachment #8354387 -
Flags: review?(florian) → review-
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 2045 as attmnt 2621 at 2013-07-20 23:17:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354390 -
Flags: review?(florian)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8354387 [details] [diff] [review] Fix for Mac *** Original change on bio 2045 attmnt 2618 at 2013-07-20 23:17:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354387 -
Attachment is obsolete: true
Comment 10•10 years ago
|
||
Comment on attachment 8354390 [details] [diff] [review] Address comments, add retina tag icons *** Original change on bio 2045 attmnt 2621 at 2013-07-20 23:27:01 UTC *** Thanks!
Attachment #8354390 -
Flags: review?(florian) → review+
Assignee | ||
Comment 11•10 years ago
|
||
*** Original post on bio 2045 at 2013-07-20 23:39:21 UTC *** http://hg.instantbird.org/instantbird/rev/7e20bdd5c790
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
Assignee | ||
Updated•10 years ago
|
Summary: Update theming of the "+" buttons → Update theming of the "+" buttons on OS X
You need to log in
before you can comment on or make changes to this bug.
Description
•