Closed Bug 955489 Opened 10 years ago Closed 10 years ago

Add a way to pref off JS prpls.

Categories

(Instantbird Graveyard :: Other, enhancement)

x86
Other
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

*** Original post on bio 2052 at 2013-07-15 07:10:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 955019
Attached patch PatchSplinter Review
*** Original post on bio 2052 as attmnt 2596 at 2013-07-15 07:10:00 UTC ***

We need this to start dogfooding JS-Yahoo and Generic JS-XMPP (bug 955019 (bio 1589)).

My first ideas to implement this were to check the pref in the getProtocolById method of imCore.js, or to add some code in jsProtoHelper so that the JS implementation can decide to act as a proxy to the libpurple implementation. However, both of these solutions have the downside of putting libpurple related stuff in chat/, which would be unfortunate as it's irrelevant for Thunderbird.

The jsProtoHelper solution would also have the downside of not working if for some reason the JS prpl implementation cannot be instantiated at all (eg. syntax error in a JS file, or missing dependent module...).


The solution I implemented here is fully in instantbird/, and messes with the category manager at startup (before imCore.init() is called!), which is actually very similar to what we do in a patch when enabling or disabling a JS prpl: it just replaces the contractid that will be used when creating a prplIProtocol instance for a given prpl id.
Attachment #8354365 - Flags: review?(clokep)
*** Original post on bio 2052 at 2013-07-15 10:28:22 UTC ***

At first glance this looks fine. Should we start using this for XMPP in this patch?
*** Original post on bio 2052 at 2013-07-15 10:32:46 UTC ***

(In reply to comment #1)
> At first glance this looks fine. Should we start using this for XMPP in this
> patch?

I was going to do it in bug 955019 (bio 1589).
Comment on attachment 8354365 [details] [diff] [review]
Patch

*** Original change on bio 2052 attmnt 2596 at 2013-07-15 10:40:04 UTC ***

>diff --git a/instantbird/app/profile/all-instantbird.js b/instantbird/app/profile/all-instantbird.js
>+// Comma separated list of prpl ids that should use libpurple even if this is a
>+// JS implementation. This is used to land JS-prpls pref'ed off in nightlies.
"even if there is a"

r+ with the above comment fixed.
Attachment #8354365 - Flags: review?(clokep) → review+
Blocks: 955419
*** Original post on bio 2052 at 2013-07-15 21:29:43 UTC ***

http://hg.instantbird.org/instantbird/rev/05a193794048
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.