Closed Bug 955498 Opened 10 years ago Closed 10 years ago

Section scroll doesn't find all sessions

Categories

(Instantbird Graveyard :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file)

*** Original post on bio 2061 at 2013-07-19 19:27:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 2061 as attmnt 2612 at 2013-07-19 19:27:00 UTC ***

This bug was caused by the Bubbles theme setting display:none on the original sessionstart ruler element (which section scroll looks for) when adding a time text. Display:none elements have no offsetTop so section scroll then ignores them.

The patch also resets the list of sessions when the convbrowser loads a new conversation (this did not actually cause any visible bugs beyond costing some memory due to the obsolete DOM references).
Attachment #8354381 - Flags: review?(florian)
Comment on attachment 8354381 [details] [diff] [review]
Patch

*** Original change on bio 2061 attmnt 2612 at 2013-07-19 22:00:16 UTC ***

>+      <!-- These variables are reset in onStateChange. -->
>       <field name="_sessions">[]</field>
>       <method name="displayMessage">

I find this comment confusing as it uses the plural form even though it refers to only one field. I'm changing it to "This is reset in onStateChange." before comitting.

Seems fine otherwise. Thanks for debugging! :-)
Attachment #8354381 - Flags: review?(florian) → review+
*** Original post on bio 2061 at 2013-07-19 22:06:45 UTC ***

http://hg.instantbird.org/instantbird/rev/43c510f7260b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.