Closed
Bug 955517
Opened 10 years ago
Closed 10 years ago
Buddy Authorization Handler Doesn't Work
Categories
(Chat Core :: Yahoo! Messenger, defect)
Chat Core
Yahoo! Messenger
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: qheaden, Assigned: qheaden)
Details
Attachments
(1 file, 1 obsolete file)
1.88 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2080 at 2013-07-29 14:23:00 UTC *** The packet handler for buddy authorization requests incorrectly sets the account getter on the authRequest object created within it. As a result, a null error is thrown later by Instantbird's buddy authorization code, and the user cannot accept or reject buddy requests.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2080 as attmnt 2653 at 2013-07-29 14:25:00 UTC *** Here is a one-line change that fixes the issue.
Attachment #8354422 -
Flags: review?(clokep)
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 2080 as attmnt 2654 at 2013-07-29 14:29:00 UTC *** Sorry for missing a couple of other changes I needed to make.
Attachment #8354423 -
Flags: review?(clokep)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8354422 [details] [diff] [review] Proposed Fix *** Original change on bio 2080 attmnt 2653 at 2013-07-29 14:29:16 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354422 -
Attachment is obsolete: true
Attachment #8354422 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Severity: critical → major
Comment 4•10 years ago
|
||
Comment on attachment 8354423 [details] [diff] [review] Proposed Fix v2 *** Original change on bio 2080 attmnt 2654 at 2013-07-29 23:29:04 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354423 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 5•10 years ago
|
||
*** Original post on bio 2080 at 2013-08-01 03:50:04 UTC *** http://hg.instantbird.org/instantbird/rev/981fe83f55c0 Thanks.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•