Closed Bug 955524 Opened 10 years ago Closed 10 years ago

Accepting an invitation to chat can end in a loop

Categories

(Chat Core :: Yahoo! Messenger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: qheaden)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 2087 at 2013-08-02 10:36:00 UTC ***

Timestamp: 08/02/2013 12:32:06 PM
Error: Attempting to store a duplicate account buddy alethtest, account id = 11, tag id = 4
Source File: resource://gre/components/imContacts.js
Line: 1311

I had already accepted a buddy auth request, but immediately received another one. On accepting it, this error was of course produced. I had two prpl-yahoo accounts connected at the same time, not sure if that is relevant. Possibly related to bug 955522 (bio 2085).
Attached patch Patch 1 (obsolete) — Splinter Review
*** Original post on bio 2087 as attmnt 2685 at 2013-08-08 18:33:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354454 - Flags: review?(clokep)
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
Comment on attachment 8354454 [details] [diff] [review]
Patch 1

*** Original change on bio 2087 attmnt 2685 at 2013-08-09 20:07:33 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354454 - Attachment is patch: true
Attachment #8354454 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 8354454 [details] [diff] [review]
Patch 1

*** Original change on bio 2087 attmnt 2685 at 2013-08-09 20:08:50 UTC ***

Can we add a comment saying what condition this occurs in?
Attachment #8354454 - Flags: review?(clokep) → review-
*** Original post on bio 2087 at 2013-08-09 20:12:16 UTC ***

(In reply to comment #2)
> Comment on attachment 8354454 [details] [diff] [review] (bio-attmnt 2685) [details]
> Patch 1
> 
> Can we add a comment saying what condition this occurs in?

We could, but doesn't kPacketStatuses.ServerAck pretty much tell when this happens? Whenever a server sends an ack packet.
*** Original post on bio 2087 at 2013-08-09 20:19:32 UTC ***

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 8354454 [details] [diff] [review] (bio-attmnt 2685) [details]
> > Patch 1
> > 
> > Can we add a comment saying what condition this occurs in?
> 
> We could, but doesn't kPacketStatuses.ServerAck pretty much tell when this
> happens? Whenever a server sends an ack packet.

It doesn't tell me what it's acking at all. ;)
Attached patch Patch 2Splinter Review
*** Original post on bio 2087 as attmnt 2692 at 2013-08-10 08:58:00 UTC ***

I hope this is a little more descriptive. ;)
Attachment #8354461 - Flags: review?(clokep)
Comment on attachment 8354454 [details] [diff] [review]
Patch 1

*** Original change on bio 2087 attmnt 2685 at 2013-08-10 08:58:34 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354454 - Attachment is obsolete: true
Comment on attachment 8354461 [details] [diff] [review]
Patch 2

*** Original change on bio 2087 attmnt 2692 at 2013-08-11 18:20:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354461 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2087 at 2013-08-13 00:43:32 UTC ***

http://hg.instantbird.org/instantbird/rev/f24ecbff1533
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.