Closed Bug 955530 Opened 10 years ago Closed 10 years ago

"Adding chat buddy twice" error when inviting someone to a chatroom

Categories

(Chat Core :: Yahoo! Messenger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: qheaden)

Details

Attachments

(1 file)

*** Original post on bio 2093 at 2013-08-02 11:53:00 UTC ***

Timestamp: 08/02/2013 01:51:55 PM
Error: [Exception... "'Adding chat buddy alethtest twice?!' when calling method: [nsIObserver::observe]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: resource:///modules/jsProtoHelper.jsm :: <TOP_LEVEL> :: line 417"  data: no]
Source File: resource:///modules/jsProtoHelper.jsm
Line: 417
Timestamp: 08/02/2013 01:51:55 PM
Error: [Exception... "'Adding chat buddy alethtest twice?!' when calling method: [nsIObserver::observe]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: resource:///modules/jsProtoHelper.jsm :: <TOP_LEVEL> :: line 417"  data: no]
Source File: resource:///modules/jsProtoHelper.jsm
Line: 419
Source Code:
prpl-yahoo
*** Original post on bio 2093 at 2013-08-02 18:41:11 UTC ***

Sometime tells me this has something to do with the server sending an acknowledgement packet. I'll look into it.
Attached patch Patch 1Splinter Review
*** Original post on bio 2093 as attmnt 2841 at 2013-09-06 18:00:00 UTC ***

This patch prevents the adding of duplicate buddies.
Attachment #8354611 - Flags: review?(clokep)
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
Comment on attachment 8354611 [details] [diff] [review]
Patch 1

*** Original change on bio 2093 attmnt 2841 at 2013-09-07 12:26:19 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354611 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2093 at 2013-09-09 23:37:14 UTC ***

http://hg.instantbird.org/instantbird/rev/ed26aded5b7d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.