Closed
Bug 955534
Opened 10 years ago
Closed 10 years ago
Chat Message Handler Can Throw Error
Categories
(Chat Core :: Yahoo! Messenger, defect)
Chat Core
Yahoo! Messenger
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: qheaden, Assigned: qheaden)
Details
Attachments
(1 file)
661 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2096 at 2013-08-07 02:18:00 UTC *** The packet handler for incoming chat messages (service 0x06) will send out an acknowledgement packet if the sender requires one (normally the official Yahoo! Messenger client). I discovered that, when sending an ack, the handler references this._session._socket. It should be this._session, since in the middle of development, YahooSession was turned into a child of Socket.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2096 as attmnt 2684 at 2013-08-07 02:20:00 UTC *** This should fix the issue.
Attachment #8354453 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8354453 [details] [diff] [review] Patch 1 *** Original change on bio 2096 attmnt 2684 at 2013-08-07 03:42:29 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354453 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 3•10 years ago
|
||
*** Original post on bio 2096 at 2013-08-11 18:11:57 UTC *** http://hg.instantbird.org/instantbird/rev/ac069ca36f4f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•