Closed Bug 955537 Opened 10 years ago Closed 10 years ago

Ensure that commands that only work in channels use CONTEXT_CHAT

Categories

(Chat Core :: IRC, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(1 file)

*** Original post on bio 2099 at 2013-08-11 18:15:00 UTC ***

See bug 955527 (bio 2090) for JS-Yahoo.
Attached patch PatchSplinter Review
*** Original post on bio 2099 as attmnt 2971 at 2013-10-19 23:05:00 UTC ***

I'd like this to make it into 1.5, it's a fairly simple fix, please look over these carefully and make sure I didn't miss any or being overzealous!
Attachment #8354752 - Flags: review?(aleth)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8354752 [details] [diff] [review]
Patch

*** Original change on bio 2099 attmnt 2971 at 2013-10-21 16:48:59 UTC ***

Looks good to me - thanks for taking care of this! (I hesitated over Chanserv, but it's a service like any other (so you can actually talk to it from a PM), so the behaviour here is correct.)
Attachment #8354752 - Flags: review?(aleth) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2099 at 2013-10-23 10:38:52 UTC ***

http://hg.instantbird.org/instantbird/rev/ee8ee4db6211
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.