955566 - Chrome file doesn't exist: messages/papersheets/Variants/default.css

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 2128 at 2013-08-26 22:07:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Trivial patch

*** Original post on bio 2128 as attmnt 2787 at 2013-08-26 22:07:00 UTC ***

When selecting the PaperSheet theme, my debug build prints this in the terminal:
Chrome file doesn't exist: /Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/chrome/instantbird/skin/classic/instantbird/messages/papersheets/Variants/default.css
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /Users/florian/buildhg/hg.instantbird.org/mozilla/netwerk/base/src/nsFileStreams.cpp, line 215
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /Users/florian/buildhg/hg.instantbird.org/mozilla/netwerk/base/src/nsFileStreams.cpp, line 487


The trivial attached patch gets rid of these warnings. Reviewers wondering why we can just remove this key from Info.plist can read the logic at http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#588

Comment 2

[aleth [:aleth]]

Comment on attachment 8354556 [details] [diff] [review]
Trivial patch

*** Original change on bio 2128 attmnt 2787 at 2013-08-27 09:14:51 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 2128 at 2013-08-27 21:24:40 UTC ***

http://hg.instantbird.org/instantbird/rev/ef66a2e95aaa