Closed Bug 955599 Opened 10 years ago Closed 10 years ago

Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantbird|

Categories

(Chat Core :: Twitter, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

Details

Attachments

(2 files, 1 obsolete file)

*** Original post on bio 2159 at 2013-09-06 14:30:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Port of changesets (obsolete) — Splinter Review
*** Original post on bio 2159 as attmnt 2839 at 2013-09-06 14:30:00 UTC ***

We should port bio 884319 and friends, all the Http.jsm changes.

This will require some changes to Yahoo also.

This patch is untested and ports the two changesets that touch Twitter + import the current file that's in m-c. Once we get onto a new enough m-c (25, I believe), we can delete this file.
Attachment #8354609 - Flags: review?(florian)
Comment on attachment 8354609 [details] [diff] [review]
Port of changesets

*** Original change on bio 2159 attmnt 2839 at 2013-09-29 13:39:06 UTC ***

Florian would like the new Http.jsm module as a patch against c-c so we can just delete the patch when upgrading to Moz 24.
Attachment #8354609 - Flags: review?(florian) → review-
*** Original post on bio 2159 at 2013-09-29 13:40:22 UTC ***

Assigning to me so I don't forget about this.
Assignee: nobody → clokep
Summary: Port bug 884319 → Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantbird|
*** Original post on bio 2159 at 2013-09-29 14:29:33 UTC ***

(In reply to comment #1)

> Florian would like the new Http.jsm module as a patch against c-c so we can
> just delete the patch when upgrading to Moz 24.

Moz 25 (otherwise that would already be possible ;-)).
*** Original post on bio 2159 as attmnt 2913 at 2013-09-30 21:25:00 UTC ***

Untested, but this adds http.jsm as a patch to mozilla/ instead of a separate Instantbird file.
Attachment #8354683 - Flags: review?(florian)
Comment on attachment 8354609 [details] [diff] [review]
Port of changesets

*** Original change on bio 2159 attmnt 2839 at 2013-09-30 21:25:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354609 - Attachment is obsolete: true
Attached patch Patch for YahooSplinter Review
*** Original post on bio 2159 as attmnt 2926 at 2013-10-03 21:38:00 UTC ***

This also fixes Yahoo.

I've now tested this patch and it works for both Twitter and Yahoo.
Attachment #8354697 - Flags: review?(qheaden)
Comment on attachment 8354697 [details] [diff] [review]
Patch for Yahoo

*** Original change on bio 2159 attmnt 2926 at 2013-10-09 19:45:01 UTC ***

Looks good to me. Thanks!
Attachment #8354697 - Flags: review?(qheaden) → review+
Comment on attachment 8354683 [details] [diff] [review]
Port of changesets v2

*** Original change on bio 2159 attmnt 2913 at 2013-10-10 16:09:57 UTC ***

I got an rs from Florian for this.
Attachment #8354683 - Flags: review?(florian)
*** Original post on bio 2159 at 2013-10-10 16:14:35 UTC ***

http://hg.instantbird.org/instantbird/rev/92a186172d7f
http://hg.instantbird.org/instantbird/rev/c19d3fe1319c
http://hg.instantbird.org/instantbird/rev/53c58fccae41
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
*** Original post on bio 2159 at 2013-10-11 01:37:33 UTC ***

Fix xpcshell bustage http://hg.instantbird.org/instantbird/rev/03c7937d8f17
You need to log in before you can comment on or make changes to this bug.