Return "UTF-8" for nsIPlatformCharset while pass kPlatformCharsetSel_FileName

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: Frank Tang, Assigned: nhottanscp)

Tracking

({intl})

Trunk
PowerPC
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
While calling nsIPlatformCharset
 with kPlatformCharsetSel_FileName on Macintosh, we currently return the charset
name of the system script.
Since MacOS X use UTF-8 for all the char* function of BSD file system functions
and define the file:/// URL as % escaped UTF-8, we probably should return
"UTF-8" on MacOS X instead.

see bug 95478 and 95481 for more information.
(Reporter)

Comment 1

16 years ago
Created attachment 46104 [details] [diff] [review]
patch, not fully tested yet.

Comment 2

16 years ago
fix spacing, remove tabs from the lines you are adding, test various OS versions
if you don't find any problems, r=brade
Summary: Retrun "UTF-8" for nsIPlatformCharset while pass kPlatformCharsetSel_FileName → Retrun "UTF-8" for nsIPlatformCharset while pass kPlatformCharsetSel_FileName

Updated

16 years ago
Keywords: intl
QA Contact: andreasb → ylong
(Reporter)

Updated

16 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

16 years ago
This is a very very risky move. Code is simple the change is huge. move it to m95
Target Milestone: --- → mozilla0.9.5
(Reporter)

Comment 4

16 years ago
move to m0.9.7
Target Milestone: mozilla0.9.5 → mozilla0.9.7
(Reporter)

Updated

16 years ago
Blocks: 103669
(Assignee)

Updated

16 years ago
Depends on: 108000
(Assignee)

Updated

16 years ago
No longer depends on: 108000
(Assignee)

Updated

16 years ago
Blocks: 108000
Summary: Retrun "UTF-8" for nsIPlatformCharset while pass kPlatformCharsetSel_FileName → Return "UTF-8" for nsIPlatformCharset while pass kPlatformCharsetSel_FileName
(Assignee)

Comment 5

16 years ago
move to 0.9.8

Target Milestone: mozilla0.9.7 → mozilla0.9.8
(Assignee)

Comment 6

16 years ago
http://developer.apple.com/techpubs/macosx/Essentials/SystemOverview/FileSystem/File_Encodings_and_Fonts.html

According to the document, BSD uses UTF-8 but HFS+ uses UTF-16.
(Reporter)

Comment 7

16 years ago
mass move to m9.9
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Reporter)

Comment 8

16 years ago
give this to nhotta, remove target
Assignee: ftang → nhotta
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.9 → ---
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2
(Assignee)

Updated

15 years ago
Target Milestone: mozilla1.2alpha → ---
This has been fixed by bug 199384.
-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.