Closed Bug 955608 Opened 8 years ago Closed 8 years ago

Update theming of the "+" buttons on OS X (non-retina image)

Categories

(Instantbird :: Conversation, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 2167 at 2013-09-12 14:43:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2167 as attmnt 2876 at 2013-09-12 14:43:00 UTC ***

The patch updates the image to the latest one from m-c (https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/newtab.png)
Attachment #8354646 - Flags: review?(florian)
Attached patch Patch 2 (obsolete) — Splinter Review
*** Original post on bio 2167 as attmnt 2878 at 2013-09-12 16:41:00 UTC ***

This adds new images for the arrows in the arrowscrollbox when the tab strip is overflowing.
Attachment #8354648 - Flags: review?(florian)
Comment on attachment 8354646 [details] [diff] [review]
Patch

*** Original change on bio 2167 attmnt 2876 at 2013-09-12 16:41:45 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354646 - Attachment is obsolete: true
Attachment #8354646 - Flags: review?(florian)
Attached patch Patch 3Splinter Review
*** Original post on bio 2167 as attmnt 2879 at 2013-09-12 16:48:00 UTC ***

This ensure that 0.5 opacity isn't applied twice to the retina icons.
Attachment #8354649 - Flags: review?(florian)
Comment on attachment 8354648 [details] [diff] [review]
Patch 2

*** Original change on bio 2167 attmnt 2878 at 2013-09-12 16:48:08 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354648 - Attachment is obsolete: true
Attachment #8354648 - Flags: review?(florian)
Comment on attachment 8354649 [details] [diff] [review]
Patch 3

*** Original change on bio 2167 attmnt 2879 at 2013-09-12 16:50:48 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354649 - Flags: review?(florian) → review+
*** Original post on bio 2167 at 2013-09-12 23:04:40 UTC ***

http://hg.instantbird.org/instantbird/rev/b77c73239ba3
Assignee: nobody → nhnt11
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.