955615 - Clicking the topic in the header of an IRC channel with no topic and focusing something else without typing anything clears the topic

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2173 at 2013-09-14 22:43:00 UTC ***

Sorry if the bug title is vague, I couldn't think of a shorter way to describe this.

STR:
1. Join a channel with no topic.
2. Click topic in conversation header.
3. Click elsewhere.
4. You'll see "<nick> has cleared the topic"

IRC discussion on this: http://pastebin.instantbird.com/339113

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 2173 as attmnt 2888 at 2013-09-15 14:39:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 2173 as attmnt 2890 at 2013-09-15 15:31:00 UTC ***

Fixes another bug on the UI side which always set the topic when the topic was empty, because always "" != "No topic message for this room" ;)

Comment 3

[aleth [:aleth]]

Comment on attachment 8354658 [details] [diff] [review]
Patch

*** Original change on bio 2173 attmnt 2888 at 2013-09-15 15:31:46 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 2173 as attmnt 2891 at 2013-09-15 15:37:00 UTC ***

Removes dump()s.

Comment 5

[aleth [:aleth]]

Comment on attachment 8354660 [details] [diff] [review]
Patch

*** Original change on bio 2173 attmnt 2890 at 2013-09-15 15:37:14 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 2173 as attmnt 2892 at 2013-09-15 15:45:00 UTC ***

One more attempt to get rid of dumps...

Comment 7

[aleth [:aleth]]

Comment on attachment 8354661 [details] [diff] [review]
Patch

*** Original change on bio 2173 attmnt 2891 at 2013-09-15 15:45:29 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[Patrick Cloke [:clokep]]

Comment on attachment 8354662 [details] [diff] [review]
Patch

*** Original change on bio 2173 attmnt 2892 at 2013-09-15 18:35:25 UTC ***

I tested this and it seems to work OK. Florian should probably take a look before committing this.

Comment 9

[Patrick Cloke [:clokep]]

*** Original post on bio 2173 at 2013-09-22 23:37:55 UTC ***

Thanks. :)

http://hg.instantbird.org/instantbird/rev/8d4d3e2c9620