Closed Bug 955617 Opened 10 years ago Closed 10 years ago

Buddy icons for contacts are not updated in the new conversation tab

Categories

(Instantbird Graveyard :: Conversation, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file)

*** Original post on bio 2175 at 2013-09-15 21:31:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch PatchSplinter Review
*** Original post on bio 2175 as attmnt 2893 at 2013-09-15 21:31:00 UTC ***

The patch makes PossibleConvFromContact instances return the current buddyIconFilename instead of a cached one, using a getter. The alternative would be to listen for account-buddy-icon-changed and update the cached value, but I figured this is simpler and inexpensive.
Attachment #8354663 - Flags: review?
Blocks: 955582
Comment on attachment 8354663 [details] [diff] [review]
Patch

*** Original change on bio 2175 attmnt 2893 at 2013-09-15 23:43:29 UTC ***

I'm seeing this problem and I'll review the patch. Just not now ;)
Attachment #8354663 - Flags: review? → review?(benediktp)
Comment on attachment 8354663 [details] [diff] [review]
Patch

*** Original change on bio 2175 attmnt 2893 at 2013-09-16 08:26:39 UTC ***

Works fine and I can't see any possible problems with this.
Attachment #8354663 - Flags: review?(benediktp) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2175 at 2013-09-22 23:38:44 UTC ***

http://hg.instantbird.org/instantbird/rev/3539548179c3

Thanks!
Assignee: nobody → nhnt11
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.