Open Bug 955618 Opened 8 years ago

Replace toLowerCase with toLocaleLowerCase where appropriate

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: benediktp, Unassigned)

Details

*** Original post on bio 2176 at 2013-09-16 08:39:00 UTC ***

There are uses of toLowerCase where toLocaleLowerCase might be more appropriate, e.g. when used in combination with localeCompare [1].
We should change these toLowerCase [2] calls to toLocaleLowerCase to make sure we catch edge-cases that seem to exist according to MDN [2].
There seemed to have been concerns [4] that this might impact performance, so maybe we should try to figure out if and if yes how severe they are.

[1] http://lxr.instantbird.org/instantbird/search?string=localeCompare
[2] http://lxr.instantbird.org/instantbird/search?string=toLowerCase
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toLocaleLowerCase
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=953891 (bio 451)#c20
You need to log in before you can comment on or make changes to this bug.