Closed Bug 955621 Opened 7 years ago Closed 7 years ago

JS Error when reordering buddies inside a contact

Categories

(Instantbird :: Contacts window, defect)

x86
Other
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: aleth)

Details

(Whiteboard: [1.5-blocking][regression])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 2179 at 2013-09-22 21:19:00 UTC ***

###!!! ASSERTION: Invalid state to get the params object - all calls will fail!: 'state == mozIStorageStatement::MOZ_STORAGE_STATEMENT_READY', file <srcdir>/mozilla/storage/src/mozStorageStatementJSHelper.cpp, line 131
JavaScript error: <objdir>/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imContacts.js, line 692: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative
Whiteboard: [1.5-blocking][regression]
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2179 as attmnt 3006 at 2013-11-02 17:09:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354787 - Flags: review?(florian)
Attached patch PatchSplinter Review
*** Original post on bio 2179 as attmnt 3007 at 2013-11-02 17:22:00 UTC ***

Only finalize once.
Attachment #8354788 - Flags: review?(florian)
Comment on attachment 8354787 [details] [diff] [review]
Patch

*** Original change on bio 2179 attmnt 3006 at 2013-11-02 17:22:34 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354787 - Attachment is obsolete: true
Attachment #8354787 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354788 [details] [diff] [review]
Patch

*** Original change on bio 2179 attmnt 3007 at 2013-11-02 17:24:05 UTC ***

Thanks for debugging this! :-)
Attachment #8354788 - Flags: review?(florian) → review+
Whiteboard: [1.5-blocking][regression] → [1.5-blocking][regression][checkin-needed]
*** Original post on bio 2179 at 2013-11-02 17:25:21 UTC ***

This is a regression from http://hg.instantbird.org/instantbird/rev/f0cdff383d78#l1.130
-> https://bugzilla.mozilla.org/show_bug.cgi?id=910226
*** Original post on bio 2179 at 2013-11-02 17:28:43 UTC ***

http://hg.instantbird.org/instantbird/rev/f62087ac9657
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-blocking][regression][checkin-needed] → [1.5-blocking][regression]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.