Closed Bug 955627 Opened 10 years ago Closed 10 years ago

Overly greedy regexp butchers topic on LIST responses

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: nhnt11)

Details

Attachments

(1 file)

*** Original post on bio 2183 at 2013-09-26 14:20:00 UTC ***

There was a list item for a channel (not joined yet) on the awesome-tab that had only the last few words of a channel's topic set on its second line.

It turned out that the regexp that is trying to remove channel modes from the LIST results [1] is too greedy.

[1] http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#811
*** Original post on bio 2183 at 2013-09-26 14:37:59 UTC ***

The string that was shown was "whiteboard flag." and the channels topic was "Use this: http://bugmotodo.org - next uplift 2013-10-28 - contribute: https://wiki.mozilla.org/DevTools/GetInvolved - meeting thursdays at 10am pacific: https://etherpad.mozilla.org/devtools-meeting2 - checkin-needed keyword is the new [land-in-fx-team] whiteboard flag." by the way.
*** Original post on bio 2183 at 2013-09-26 16:48:58 UTC ***

/^\[\+.*\] / probably needs to be /^\[\+[a-zA-Z]+\] /
Attached patch PatchSplinter Review
*** Original post on bio 2183 as attmnt 2907 at 2013-09-26 17:57:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354677 - Flags: review?(clokep)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment on attachment 8354677 [details] [diff] [review]
Patch

*** Original change on bio 2183 attmnt 2907 at 2013-09-26 22:12:01 UTC ***

I think this will work better, did you confirm that this fixes it?
Attachment #8354677 - Flags: review?(clokep) → review+
*** Original post on bio 2183 at 2013-09-26 22:19:09 UTC ***

I've tested the patch and it fixes the reported bug.
Whiteboard: [checkin-needed]
*** Original post on bio 2183 at 2013-10-01 23:13:15 UTC ***

http://hg.instantbird.org/instantbird/rev/07227be16b3d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.