Closed
Bug 955627
Opened 10 years ago
Closed 10 years ago
Overly greedy regexp butchers topic on LIST responses
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: benediktp, Assigned: nhnt11)
Details
Attachments
(1 file)
1.39 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2183 at 2013-09-26 14:20:00 UTC *** There was a list item for a channel (not joined yet) on the awesome-tab that had only the last few words of a channel's topic set on its second line. It turned out that the regexp that is trying to remove channel modes from the LIST results [1] is too greedy. [1] http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#811
Reporter | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2183 at 2013-09-26 14:37:59 UTC *** The string that was shown was "whiteboard flag." and the channels topic was "Use this: http://bugmotodo.org - next uplift 2013-10-28 - contribute: https://wiki.mozilla.org/DevTools/GetInvolved - meeting thursdays at 10am pacific: https://etherpad.mozilla.org/devtools-meeting2 - checkin-needed keyword is the new [land-in-fx-team] whiteboard flag." by the way.
Comment 2•10 years ago
|
||
*** Original post on bio 2183 at 2013-09-26 16:48:58 UTC *** /^\[\+.*\] / probably needs to be /^\[\+[a-zA-Z]+\] /
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 2183 as attmnt 2907 at 2013-09-26 17:57:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354677 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8354677 [details] [diff] [review] Patch *** Original change on bio 2183 attmnt 2907 at 2013-09-26 22:12:01 UTC *** I think this will work better, did you confirm that this fixes it?
Attachment #8354677 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 2183 at 2013-09-26 22:19:09 UTC *** I've tested the patch and it fixes the reported bug.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 2183 at 2013-10-01 23:13:15 UTC *** http://hg.instantbird.org/instantbird/rev/07227be16b3d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•