Closed
Bug 955633
Opened 10 years ago
Closed 10 years ago
Port 'Bug 846540 - Emasculate comm-central/configure.in'
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(2 files, 2 obsolete files)
232.17 KB,
patch
|
Details | Diff | Splinter Review | |
1.36 KB,
patch
|
Details | Diff | Splinter Review |
*** Original post on bio 2188 at 2013-09-28 21:43:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2188 as attmnt 2911 at 2013-09-28 21:43:00 UTC *** The attached patch ports the changes from Bio 846540 - Emasculate comm-central/configure.in, but unfortunately the resulting repository doesn't work because the subconfigures don't use autoconf, but only a very small subset of the autoconf functions defined in http://mxr.mozilla.org/mozilla-central/source/build/autoconf/subconfigure.m4 I don't see an obvious way forward right now. Just filing this bug to attach my WIP somewhere.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 2188 at 2013-10-10 21:10:04 UTC *** (In reply to comment #0) > I don't see an obvious way forward right now. Our options are: 1. Keep the libpurple specific checks in the top level configure.in file that uses autoconf. This gets us most of the configure.in cleanup, but doesn't let us get really in sync with the c-c configure, so it's not enough if we want to merge into c-c. 2. Make the subconfigure work by including by hand in it all the autoconf macros that are used by our checks. Seems painful and ugly. 3. Make the mozilla-central subconfigure stuff include the macros we need, so that our subconfigure works with our libpurple specific checks. This requires discussion with others outside of the Instantbird team. 4. Remove the libpurple specific configure checks, and "hardcode" the results of the checks with platform-ifdefs in a libpurple config header inside the purple/libpurple/ folder. This is a bit ugly, but is what we have already done for glib and xml2. This won't work for the pkg-config stuff though. After sleeping on this several nights (or weeks :-S), my proposal is: - short term, do 1. - longer term: do a mix of 2, 3 and 4. I think we will really need PKG_CHECK_MODULES to work, so we would do either 2. or 3. for it (possibly a mix of both, like including in subconfigure.m4 some macros that PKG_CHECK_MODULES depends on, but define PKG_CHECK_MODULES itself inside our own script... if getting PKG_CHECK_MODULES to work inside subconfigure.m4 can't be negociated). For the other stuff (detecting if headers exist, or the size of size_t), I think 4. will work, and will simplify things.
Comment 3•10 years ago
|
||
*** Original post on bio 2188 at 2013-10-10 21:14:26 UTC *** I think this is a reasonable approach, do we have any idea how feasible these would be if libpurple was compiled as an extension?
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 2188 as attmnt 2973 at 2013-10-21 23:19:00 UTC *** This inlines PKG_CHECK_MODULES and all its dependencies inside the sub configure. It's ugly but it works. Left to do: hard code the values of HAVE_ARPA_NAMESER_COMPAT_H HAVE_INET_NTOP SIZEOF_TIME_T HAVE_TIMEZONE HAVE_TM_GMTOFF in a header file in the libpurple folder.
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8354681 [details] [diff] [review] WIP *** Original change on bio 2188 attmnt 2911 at 2013-10-21 23:19:59 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354681 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
*** Original post on bio 2188 as attmnt 2986 at 2013-10-26 22:05:00 UTC *** First complete patch, but still labeled "WIP" because my local build hasn't finished yet.
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8354754 [details] [diff] [review] WIP2 *** Original change on bio 2188 attmnt 2973 at 2013-10-26 22:05:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354754 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Assignee | ||
Comment 8•10 years ago
|
||
*** Original post on bio 2188 as attmnt 2987 at 2013-10-26 23:17:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Assignee | ||
Comment 9•10 years ago
|
||
*** Original post on bio 2188 at 2013-10-26 23:42:15 UTC *** Pushed attachment 8354767 [details] [diff] [review] (bio-attmnt 2986) + attachment 8354768 [details] [diff] [review] (bio-attmnt 2987) as http://hg.instantbird.org/instantbird/rev/19bcf91d985d with rs=clokep over IRC.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•