Closed Bug 955634 Opened 10 years ago Closed 10 years ago

package-manifest:35: Missing file(s): bin/uninstall/helper.exe

Categories

(Instantbird Graveyard :: Other, defect)

x86
Windows XP
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

References

Details

(Whiteboard: [1.5-blocking][possible regression])

Attachments

(1 file)

*** Original post on bio 2189 at 2013-09-30 12:38:00 UTC ***

On Windows 'make package' produces this warning (among others):
Warning: e:\bb-slave\win32\obj-instantbird\instantbird\installer\package-manifest:35: Missing file(s): bin/uninstall/helper.exe

I think we need to check if this is just noise or breaks the uninstall path before releasing any new version.
Whiteboard: [1.5-blocking][possible regression]
*** Original post on bio 2189 at 2013-09-30 12:40:42 UTC ***

Note: this is NOT caused by the moz24 update. I looked further in older buildbot logs, and builds based on moz23 and even moz22 have this warning.
*** Original post on bio 2189 at 2013-11-11 13:26:27 UTC ***

This is from [1], which is Mozilla 14!

[1] Bio 604266 - Remove '--disable-installer' option and 'MOZ_INSTALLER' variable: https://bugzilla.mozilla.org/show_bug.cgi?id=604266

Patch coming soon.
Assignee: nobody → clokep
Severity: normal → major
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
*** Original post on bio 2189 as attmnt 3030 at 2013-11-11 13:28:00 UTC ***

I checked and this is the only usage of MOZ_INSTALLER in Instantbird.
Attachment #8354811 - Flags: review?(florian)
*** Original post on bio 2189 at 2013-11-11 13:29:34 UTC ***

Also, IB 1.2 was the version released on Mozilla 14, so it's possible we haven't had an uninstaller since then?
Blocks: 955017
Comment on attachment 8354811 [details] [diff] [review]
Patch

*** Original change on bio 2189 attmnt 3030 at 2013-11-11 15:04:36 UTC ***

Thanks!
Attachment #8354811 - Flags: review?(florian) → review+
*** Original post on bio 2189 at 2013-11-11 15:51:10 UTC ***

http://hg.instantbird.org/instantbird/rev/0762f55e4717
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.