Typo prevents stats service from sweeping logs

RESOLVED FIXED in 1.5

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

trunk
x86
Other

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
*** Original post on bio 2193 at 2013-10-02 09:46:00 UTC ***

s/statsservice/statsService here: http://hg.instantbird.org/instantbird/rev/8d0e7525f85f#l2.206

This presents a new problem as well: we need a way to force a resweep of the logs. I propose a pref that forces a resweep on next restart, and to set this pref to false at the end of a sweep.
(Assignee)

Comment 1

5 years ago
Created attachment 8354690 [details] [diff] [review]
Patch

*** Original post on bio 2193 as attmnt 2920 at 2013-10-02 22:10:00 UTC ***

- Fix typo
- Add versioning to the stats cache file
- Resort all conversations after a log sweep
Attachment #8354690 - Flags: review?(florian)
(Assignee)

Updated

5 years ago
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 8354691 [details] [diff] [review]
Patch 2

*** Original post on bio 2193 as attmnt 2921 at 2013-10-02 22:35:00 UTC ***

Remove version from gStatsByConvId, use a wrapper object (i.e. {version: gStatsCacheVersion, stats: gStatsByConvId}).
Attachment #8354691 - Flags: review?(florian)
(Assignee)

Comment 3

5 years ago
Comment on attachment 8354690 [details] [diff] [review]
Patch

*** Original change on bio 2193 attmnt 2920 at 2013-10-02 22:35:24 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354690 - Attachment is obsolete: true
Attachment #8354690 - Flags: review?(florian)
Comment on attachment 8354691 [details] [diff] [review]
Patch 2

*** Original change on bio 2193 attmnt 2921 at 2013-10-02 22:40:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354691 - Flags: review?(florian) → review+
*** Original post on bio 2193 at 2013-10-03 13:47:23 UTC ***

http://hg.instantbird.org/instantbird/rev/4d9f3715c0e9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.