Closed
Bug 955638
Opened 10 years ago
Closed 10 years ago
Typo prevents stats service from sweeping logs
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: nhnt11, Assigned: nhnt11)
Details
Attachments
(1 file, 1 obsolete file)
5.37 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2193 at 2013-10-02 09:46:00 UTC *** s/statsservice/statsService here: http://hg.instantbird.org/instantbird/rev/8d0e7525f85f#l2.206 This presents a new problem as well: we need a way to force a resweep of the logs. I propose a pref that forces a resweep on next restart, and to set this pref to false at the end of a sweep.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2193 as attmnt 2920 at 2013-10-02 22:10:00 UTC *** - Fix typo - Add versioning to the stats cache file - Resort all conversations after a log sweep
Attachment #8354690 -
Flags: review?(florian)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 2193 as attmnt 2921 at 2013-10-02 22:35:00 UTC *** Remove version from gStatsByConvId, use a wrapper object (i.e. {version: gStatsCacheVersion, stats: gStatsByConvId}).
Attachment #8354691 -
Flags: review?(florian)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8354690 [details] [diff] [review] Patch *** Original change on bio 2193 attmnt 2920 at 2013-10-02 22:35:24 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354690 -
Attachment is obsolete: true
Attachment #8354690 -
Flags: review?(florian)
Comment 4•10 years ago
|
||
Comment on attachment 8354691 [details] [diff] [review] Patch 2 *** Original change on bio 2193 attmnt 2921 at 2013-10-02 22:40:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354691 -
Flags: review?(florian) → review+
Comment 5•10 years ago
|
||
*** Original post on bio 2193 at 2013-10-03 13:47:23 UTC *** http://hg.instantbird.org/instantbird/rev/4d9f3715c0e9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•